i2c: bcm2835: Make clock-stretch timeout configurable #4855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default clock-stretch timeout is 35 mS, which works well for SMBus, but there are some I2C devices which can stretch the clock even longer. Rather than trying to prescribe a safe default for everyone, allow the timeout to be configured. Signed-off-by: Alex Crawford <raspberrypi/[email protected]>
Contributor
|
Thanks - we should probably add an override from Device Tree as well. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 2, 2022
kernel: Patching lan78xx for SOF_TIMESTAMPING_TX_SOFTWARE support See: raspberrypi/linux#4856 kernel: i2c: bcm2835: Make clock-stretch timeout configurable See: raspberrypi/linux#4855 kernel: drm/vc4: Add DRM 210101010 RGB formats for hvs5. See: raspberrypi/linux#4859 kernel: vc4-kms-dpi overlay updates See: raspberrypi/linux#4860 kernel: Add Support for the Geekworm MZP280 DPI Display See: raspberrypi/linux#4853 kernel: DRM: Clean up handling of panel orientation See: raspberrypi/linux#4862 kernel: Add support for the MAX30102 heart rate and blood oxygen sensor See: raspberrypi/linux#4535 firmware: mmal: Add mapping for IL OMX_IndexParamBrcmEnableIJGTableScaling param See: raspberrypi/linux#4669 userland: Handle overlay parameters embedded in overlay_map.dtb See: raspberrypi/linux#4860
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 2, 2022
kernel: Patching lan78xx for SOF_TIMESTAMPING_TX_SOFTWARE support See: raspberrypi/linux#4856 kernel: i2c: bcm2835: Make clock-stretch timeout configurable See: raspberrypi/linux#4855 kernel: drm/vc4: Add DRM 210101010 RGB formats for hvs5. See: raspberrypi/linux#4859 kernel: vc4-kms-dpi overlay updates See: raspberrypi/linux#4860 kernel: Add Support for the Geekworm MZP280 DPI Display See: raspberrypi/linux#4853 kernel: DRM: Clean up handling of panel orientation See: raspberrypi/linux#4862 kernel: Add support for the MAX30102 heart rate and blood oxygen sensor See: raspberrypi/linux#4535 firmware: mmal: Add mapping for IL OMX_IndexParamBrcmEnableIJGTableScaling param See: raspberrypi/linux#4669 userland: Handle overlay parameters embedded in overlay_map.dtb See: raspberrypi/linux#4860
Contributor
Author
|
I think a misunderstood the branching strategy. How do I ensure this patch continues being applied to newer branches? |
Contributor
|
It's already been copied over, although it's been squashed: https://github.com/raspberrypi/linux/blob/rpi-5.15.y/drivers/i2c/busses/i2c-bcm2835.c#L58 |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 16, 2022
kernel: overlays: rpi-poe(-plus): Fix parameters See: raspberrypi/linux#4877 kernel: i2c: bcm2835: Make clock-stretch timeout configurable See: raspberrypi/linux#4855 kernel: Add DPI mode 3 (rgb565-padhi) support to vc4-kms-dpi-generic See: raspberrypi/linux#4882 kernel: media: i2c: imx219: Scale the pixel clock rate for the 640x480 mode See: raspberrypi/linux#4880 kernel: vc4_dpi fixes See: raspberrypi/linux#4889 kernel: Change vc4 DSI to being a bridge See: raspberrypi/linux#4878 kernel: sc16is7xx: Fix for incorrect data being transmitted See: raspberrypi/linux#4885
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 16, 2022
kernel: overlays: rpi-poe(-plus): Fix parameters See: raspberrypi/linux#4877 kernel: i2c: bcm2835: Make clock-stretch timeout configurable See: raspberrypi/linux#4855 kernel: Add DPI mode 3 (rgb565-padhi) support to vc4-kms-dpi-generic See: raspberrypi/linux#4882 kernel: media: i2c: imx219: Scale the pixel clock rate for the 640x480 mode See: raspberrypi/linux#4880 kernel: vc4_dpi fixes See: raspberrypi/linux#4889 kernel: Change vc4 DSI to being a bridge See: raspberrypi/linux#4878 kernel: sc16is7xx: Fix for incorrect data being transmitted See: raspberrypi/linux#4885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default clock-stretch timeout is 35 mS, which works well for
SMBus, but there are some I2C devices which can stretch the clock even
longer. Rather than trying to prescribe a safe default for everyone,
allow the timeout to be configured.
Signed-off-by: Alex Crawford raspberrypi/[email protected]