Skip to content

Conversation

flavorjones
Copy link
Collaborator

This is meant to be a version of #135 with smaller changes to figure out where things start to go wrong. I will throw it away once I've diagnosed the issue, and then will fix #135.

@flavorjones flavorjones force-pushed the flavorjones-bump-rubies-small-steps branch 2 times, most recently from a78b761 to 8309e03 Compare December 29, 2024 17:03
@flavorjones flavorjones force-pushed the flavorjones-bump-rubies-small-steps branch from 87cde11 to f494ebe Compare December 29, 2024 18:49
@mudge
Copy link

mudge commented Dec 31, 2024

I asked @tomstuart to test the failing arm64-darwin gem on macOS 14 Sonoma (darwin23 rather than the darwin24 of my development machine) but he also gets a passing test suite with Ruby 3.0.7 installed by ruby-install.

I’m not sure what could be different between the GitHub Actions runners and our machines but in the worst case, would you consider including the patch for C++ extensions for Ruby 3.0.0: ruby/ruby#4429

@flavorjones flavorjones force-pushed the flavorjones-bump-rubies-small-steps branch from 1e7da2e to 4400e34 Compare January 4, 2025 15:04
Because otherwise we started to run into errors during configuration
of ruby with the 3.0.x series.
@flavorjones flavorjones force-pushed the flavorjones-bump-rubies-small-steps branch from 4400e34 to 3c2293b Compare January 5, 2025 14:26
@flavorjones flavorjones force-pushed the flavorjones-bump-rubies-small-steps branch 3 times, most recently from 149f696 to efff139 Compare January 5, 2025 14:37
@flavorjones
Copy link
Collaborator Author

Currently running CI with

  • ruby 3.0.5 to repro the failure
  • no stripping of the binaries to see if we can get better failure messages
  • just darwin and source builds for faster feedback loops

@flavorjones flavorjones force-pushed the flavorjones-bump-rubies-small-steps branch 4 times, most recently from 84896cb to 1e2b987 Compare January 5, 2025 15:32
@flavorjones flavorjones force-pushed the flavorjones-bump-rubies-small-steps branch 3 times, most recently from 114acfd to 6e1c6b7 Compare January 5, 2025 17:03
It looks like -bundle-loader was backported to 2.7.7, 3.0.5, and 3.1.3
in addition to being present in 3.2 and later.
@flavorjones flavorjones force-pushed the flavorjones-bump-rubies-small-steps branch from 6e1c6b7 to fabb70e Compare January 5, 2025 17:13
@flavorjones
Copy link
Collaborator Author

OK, looks like adding -Wl,-flat_namespace to all rubies where -bundle_loader is used makes this all work. Cherry picking that change to #135.

@flavorjones
Copy link
Collaborator Author

ok, looks like #135 is going to go green, so closing this.

@flavorjones flavorjones closed this Jan 5, 2025
@flavorjones flavorjones deleted the flavorjones-bump-rubies-small-steps branch January 5, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants