-
Notifications
You must be signed in to change notification settings - Fork 32
dep: bump all rubies' patch level #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5eff8e1
to
7548777
Compare
@mudge Just to keep you in the loop here. I've got all of the ruby patch-level updates working except for 2.7 and 3.0 (the one you originally asked for!) which are failing on Darwin. Good news: the issue seems to be the same in both:
Bad news: I don't have any mac hardware that I can use to reproduce and diagnose, so I'm falling back to trying to debug this through repeated Github Action runs, which is going to take a while. If you've got time to reproduce this on a local mac, then maybe we can pair on isolating what the missing symbol is. I previously fixed an issue with our osxcross build that was similar but not the same: #60 If not, well, with a little patience and time I'll figure it out. |
I have access to both an Intel and Apple silicon Mac so I’m happy to try to reproduce this locally: what would you like me to try running? We can try to coordinate pairing too: I might have time this evening (after 7:30pm UK time). |
9788bcb
to
ed8735d
Compare
ec6cca0
to
eae6a5d
Compare
@mudge Thanks. First see if you can reproduce it:
Ideally you should see:
But if you're reproducing the issue, you'll see something like:
|
Prior to seeing your latest reply, I just downloaded the built gem from your failing run, installed it, and when I tried to require
Let me follow your steps above now. |
@mudge I believe the error you're seeing should only happen when you're running a prerelease ruby version (e.g., 3.4.0-preview2 or something). Is that the case? |
Meantime I'm running some experiments at #136 to try to isolate which of the changes I made in this PR is causing the problem. |
Unfortunately I can't get past the build stage which fails with the following error on macOS 15.2:
|
Yes, you’re right. If I switch to, e.g. 3.3.6, I can require rcd_test without issue. |
@mudge OK, then can you try that running Ruby 3.0.7? |
It took a while to get it installed but it seems to run the tests fine locally on my Apple silicon Mac:
|
Blurgh. OK, thanks for doing that. I'm not sure there's anything else you can do at this point, if we can't reproduce it outside of the Actions runner. I'll keep at it in #136 for a bit. |
I just tried the x86_64-darwin gem on an Intel Mac with macOS 12.7 and the tests pass there too. |
Just curious, have you tried to see if it fails the same way on GHA Not sure how much it helps, but I have Intel macOS 14/Sonoma hardware available to test with, if it's useful. |
@chadlwilson Is there a particular reason you think this would work on macos-15? I have no reason to believe that this is macos-specific at this point. |
No particular reason to believe it will work. Since it seemed to be something specific to the GHA MacOS runners - if it did happen to pass on one runner but not another we could perhaps compare the inventory of the versions of everything pre-installed on those runners to see what might be causing the problem. |
eae6a5d
to
e0ad34e
Compare
3f54cfd
to
3ab4666
Compare
2957fb3
to
3dc21cb
Compare
OK, pushed a fix for the Also pushed a fix for the 'miniruby' issue in ruby I think this should go green? |
- 3.4.1 → 3.4.1 [^1] - 3.3.5 → 3.3.5 [^1] - 3.2.0 → 3.2.6 - 3.1.0 → 3.1.2 [^2] - 3.0.0 → 3.0.7 - 2.7.0 → 2.7.8 - 2.6.0 → 2.6.10 - 2.5.0 → 2.5.9 - 2.4.0 → 2.4.10 And update the default rbenv from 3.1.3 to 3.1.6. [^1]: unchanged [^2]: not the latest 3.1.6 because ruby/ruby#6193 broke cross-compilation builds until it was fixed in 3.2.0.rc2 by ruby/ruby#6944 and ruby/ruby#6959 which weren't backported (see https://bugs.ruby-lang.org/issues/19239)
3dc21cb
to
38084cf
Compare
This went green. Trying one more build without setting |
Because otherwise we started to run into errors during configuration of ruby with the 3.0.x series.
It looks like -bundle-loader was backported to 2.7.7, 3.0.5, and 3.1.3 in addition to being present in 3.2 and later.
This works around the problem described in https://bugs.ruby-lang.org/issues/19239
38084cf
to
b887a5b
Compare
looks like we need the PKG_CONFIG_USE_NATIVE_VARIABLES, though I don't fully understand why it's just Ruby 3.1. 🤷 moving on with my life. |
@mudge See https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.8.0. Let me know if you hit any snags. |
Impressive - great stuff @flavorjones ! |
Thanks for all your hard work on this, @flavorjones. I've now released re2 2.15.0 precompiled with rake-compiler-dock 1.8.0 for Ruby versions 2.6, 2.7, 3.0, 3.1, 3.2, 3.3, and 3.4 and will report back if there are any issues. |
This reflects the changes made in rake-compiler/rake-compiler-dock#135. While this requires packages to update their `RUBY_CC_VERSION` to use Ruby patches across the board, this is already needed for Ruby 3.3.5. This change at least makes this consistent. See https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.8.0.
This reflects the changes made in rake-compiler/rake-compiler-dock#135. While this requires packages to update their `RUBY_CC_VERSION` to use Ruby patches across the board, this is already needed for Ruby 3.3.5. This change at least makes this consistent. See https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.8.0.
This reflects the changes made in rake-compiler/rake-compiler-dock#135. While this requires packages to update their `RUBY_CC_VERSION` to use Ruby patches across the board, this is already needed for Ruby 3.3.5. This change at least makes this consistent. See https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.8.0.
#134 requested bumping Ruby 3.0.
Let's see what happens if we bump them all.
Bump rubies:
Other changes:
miniruby
to address https://bugs.ruby-lang.org/issues/19239 (this fix appeared in 3.2.0 but was not backported)cc @mudge
Footnotes
unchanged because it's already the latest ↩ ↩2