[Backport for 5.x] Fix cross-platform issue when loading nested files #2902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrofurtado
changed the title
Member
Author
|
Thanks @gauravtiwari ! PS: For any reason, sometimes 2 specific builds not passes. Appears an error in nokogiri. Examples: Is there something that I can help with it? I have no clue about what is the root cause of it 🙈 |
Member
Author
|
updates: I created a PR for this: #2903 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is a backport, for 5.x versions, of this PR: #2730
It fixed issues when loading nested files in platforms that are not linux (Windows, for example), normalizing it and providing the same behavior in any platform.
It also closes #2899.