Fix cross-platform issue when loading nested files #2730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- nested files would be given incorrect names in the webpack manifest - for instance, a file like `images/icons/a.svg` would end up at `icons/a.svg`, but a file like `images/b.svg` would end up at `images/b.svg` (correctly) - webpacker.yml config files generally follow a POSIX path naming convention (so source_path might be something like 'app/javascript') - the webpacker file loader config checks to see if a given file is in the source path by calling `includes` and passing the source path - on Windows, the file names resolve to strings with backslashes as separators, but the source path has a forward slash - the issue *could* be fixed by just changing the .yml file to have a backslash for the source path, but it would then break on POSIX systems - instead, we check that the *normalized* source path is contained within the file, which fixes the issue
|
@aardvarkk this is a different issue that I also experience. I just stopped nested files to not be bothered by this :D |
Member
|
thank you 🙏 |
This was referenced Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
images/icons/a.svgwould end up aticons/a.svginstead ofimages/icons/a.svg, but a file likeimages/b.svgwould end up atimages/b.svg(correctly)convention (so source_path might be something like 'app/javascript')
the source path by calling
includesand passing the source pathseparators, but the source path has a forward slash
backslash for the source path, but it would then break on POSIX
systems
within the file, which fixes the issue