Move Mnesia-specific code to rabbit_db* modules
#6430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
reorganize-code-for-khepri-phase1
branch
3 times, most recently
from
e2486e4 to
41627e0
Compare
dumbbell
force-pushed
the
reorganize-code-for-khepri-phase1
branch
from
41627e0 to
2c5d75e
Compare
Collaborator
Author
|
I converted this patch back a draft. I'm preparing another patch to sort out the Mnesia directory issue. I will later update this patch accordingly. Update: See #6462. |
dumbbell
force-pushed
the
reorganize-code-for-khepri-phase1
branch
from
2c5d75e to
bc523c3
Compare
This comment was marked as spam.
This comment was marked as spam.
dumbbell
force-pushed
the
reorganize-code-for-khepri-phase1
branch
from
bc523c3 to
1f5370e
Compare
the-mikedavis
approved these changes
Dec 9, 2022
The second argument is a list of tuples, not one tuple.
One testsuite was using strings to check the non-existence of a user and a virtual host. Given these names are expected to be binaries, for sure strings won't match.
…time_parameters` So far, `rabbit_runtime_parameters` could be called with invalid terms. There are probably still places in the code which lack this kind of verification.
RabbitMQ lacks argument verifications in many places unfortunately. Several testcases were passing bad arguments to the command but were also comparing the result to bad data. This happened to "work"...
dumbbell
force-pushed
the
reorganize-code-for-khepri-phase1
branch
from
1f5370e to
527984c
Compare
dcorbacho
approved these changes
Dec 13, 2022
The idea is to isolate in those modules the code to handle the records in the database. For now, we only support Mnesia, but there is work in progress to move to another database engine. Doing this reorganization of the code will also isolate the changes of this upcoming database engine switch, making them easier to rebase and review. In the end, the `rabbit_db*` modules should export functions for each operations we want to perform. Things like "add this record", "list records matching that", "update a record using an anonymous function inside a transaction", etc. Only the following subsystems are impacted in this commit: * virtual vhosts * internal users * runtime parameters They were modified together because they depend on each other.
This patch adapts several testcases to this behavior change. The goal is to avoid transactions where there is no need for one.
dumbbell
force-pushed
the
reorganize-code-for-khepri-phase1
branch
from
527984c to
46b71e8
Compare
Collaborator
Author
|
This change was intended to be a non-functional change. In the end, it's not entirely the case: deleting a non-existing vhost or user succeeds (the delete operations are idempotent). Before, it would have thrown an exception. This simplifies the transactional code a lot. |
dumbbell
added a commit
that referenced
this pull request
Dec 14, 2022
…eted This was the case before the reorganize of the code made in #6430 and therefore a regression in the mentionned pull request. This patch restores the behavior. Note that this is already like that for internal users. Thus, the behavior and `rabbit_db_*` are consistent.
This was referenced Jan 13, 2023
dumbbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
This should have been handled in #6430 but was missed unfortunately.
dumbbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
This should have been handled in #6430 but was missed unfortunately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to isolate in those modules the code to handle the records in the database. For now, we only support Mnesia, but there is work in progress to move to another database engine. Doing this reorganization of the code will also isolate the changes of this upcoming database engine switch, making them easier to rebase and review.
In the end, the
rabbit_db*modules should export functions for each operations we want to perform. Things like "add this record", "list records matching that", "update a record using an anonymous function inside a transaction", etc.Only the following subsystems are impacted in this commit:
They were modified together because they depend on each other.
It is a preparation step to be able to change the database layer.