rabbit_db: Add clustering-related functions #6882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
move-clustering-functions-to-rabbit_db
branch
2 times, most recently
from
ddf638d to
74ca25b
Compare
dumbbell
force-pushed
the
move-clustering-functions-to-rabbit_db
branch
6 times, most recently
from
f4e8504 to
6258637
Compare
dumbbell
force-pushed
the
move-clustering-functions-to-rabbit_db
branch
3 times, most recently
from
0ea635e to
21cff15
Compare
dumbbell
force-pushed
the
move-clustering-functions-to-rabbit_db
branch
from
21cff15 to
f30b43c
Compare
dumbbell
force-pushed
the
move-clustering-functions-to-rabbit_db
branch
from
f30b43c to
fab106b
Compare
the-mikedavis
previously approved these changes
Feb 21, 2023
dcorbacho
previously approved these changes
Feb 22, 2023
…sia` These functions extend the functionality of `erlang:is_process_alive/1` to take into account the node a process is running on and its cluster membership. These functions are moved away from `rabbit_mnesia` because we don't want `rabbit_mnesia` to be a central piece of RabbitMQ. Classic-mirrored-queue-related modules continue to use `rabbit_mnesia` functions, therefore relying on Mnesia, because they depend entirely on Mnesia anyway. They will go away at the same time as our use of Mnesia. So by keeping this code untouched, we avoid possible regressions.
This new module sits on top of `rabbit_mnesia` and provide an API with all cluster-related functions. `rabbit_mnesia` should be called directly inside Mnesia-specific code only, `rabbit_mnesia_rename` or classic mirrored queues for instance. Otherwise, `rabbit_db_cluster` must be used. Several modules, in particular in `rabbitmq_cli`, continue to call `rabbit_mnesia` as a fallback option if the `rabbit_db_cluster` module unavailable. This will be the case when the CLI will interact with an older RabbitMQ version. This will help with the introduction of a new database backend.
... instead of using an internal implementation. The plugins are `rabbitmq_peer_discovery_common` and `rabbitmq_sharding`. References #7058.
dumbbell
dismissed stale reviews from dcorbacho and the-mikedavis
via
cd2b4c7
dumbbell
force-pushed
the
move-clustering-functions-to-rabbit_db
branch
from
fab106b to
cd2b4c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
rabbit_db_clustermodule sits on top ofrabbit_mnesiaand provide an API with all cluster-related functions.rabbit_mnesiashould be called directly inside Mnesia-specific code only,rabbit_mnesia_renameor classic mirrored queues for instance. Otherwise,rabbit_db_clustermust be used.Several modules, in particular in
rabbitmq_cli, continue to callrabbit_mnesiaas a fallback option if therabbit_db_clustermodule unavailable. This will be the case when the CLI will interact with an older RabbitMQ version.This is a follow-up to #6430. It depends on #7058. It is a preparation step to be able to change the database layer.