Skip to content

rabbit_lager: Multiply high watermark by 100 when log level is debug #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2019
Merged

rabbit_lager: Multiply high watermark by 100 when log level is debug #1912

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a38d116
rabbit_lager: Multiply high watermark by 100 when log level is debug
dumbbell Mar 13, 2019
13f4117
Add check for integer value
lukebakken Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions src/rabbit_lager.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,26 +63,35 @@ set_log_level(Level) ->
set_log_level(true, Level) ->
SinksAndHandlers = [{Sink, gen_event:which_handlers(Sink)} ||
Sink <- lager:list_all_sinks()],
set_sink_log_level(SinksAndHandlers, Level);
DefaultHwm = application:get_env(lager, error_logger_hwm_original, 50),
Hwm = case Level of
debug -> DefaultHwm * 100;
_ -> DefaultHwm
end,
application:set_env(lager, error_logger_hwm, Hwm),
set_sink_log_level(SinksAndHandlers, Level, Hwm);
set_log_level(_, Level) ->
{error, {invalid_log_level, Level}}.

set_sink_log_level([], _Level) ->
set_sink_log_level([], _Level, _Hwm) ->
ok;
set_sink_log_level([{Sink, Handlers}|Rest], Level) ->
set_sink_handler_log_level(Sink, Handlers, Level),
set_sink_log_level(Rest, Level).
set_sink_log_level([{Sink, Handlers}|Rest], Level, Hwm) ->
set_sink_handler_log_level(Sink, Handlers, Level, Hwm),
set_sink_log_level(Rest, Level, Hwm).

set_sink_handler_log_level(_Sink, [], _Level) ->
set_sink_handler_log_level(_Sink, [], _Level, _Hwm) ->
ok;
set_sink_handler_log_level(Sink, [Handler|Rest], Level) when is_atom(Handler) ->
set_sink_handler_log_level(Sink, [Handler|Rest], Level, Hwm)
when is_atom(Handler) andalso is_integer(Hwm) ->
lager:set_loghwm(Sink, Handler, undefined, Hwm),
ok = lager:set_loglevel(Sink, Handler, undefined, Level),
set_sink_handler_log_level(Sink, Rest, Level);
set_sink_handler_log_level(Sink, [{Handler, Id}|Rest], Level) ->
set_sink_handler_log_level(Sink, Rest, Level, Hwm);
set_sink_handler_log_level(Sink, [{Handler, Id}|Rest], Level, Hwm) ->
lager:set_loghwm(Sink, Handler, Id, Hwm),
ok = lager:set_loglevel(Sink, Handler, Id, Level),
set_sink_handler_log_level(Sink, Rest, Level);
set_sink_handler_log_level(Sink, [_|Rest], Level) ->
set_sink_handler_log_level(Sink, Rest, Level).
set_sink_handler_log_level(Sink, Rest, Level, Hwm);
set_sink_handler_log_level(Sink, [_|Rest], Level, Hwm) ->
set_sink_handler_log_level(Sink, Rest, Level, Hwm).

log_locations() ->
ensure_lager_configured(),
Expand Down Expand Up @@ -293,7 +302,7 @@ configure_lager() ->
{ok, Val} when is_integer(Val) andalso Val < 1000 ->
ok = application:set_env(lager, error_logger_hwm, 1000),
ok = application:set_env(lager, error_logger_hwm_original, Val);
{ok, Val} ->
{ok, Val} when is_integer(Val) ->
ok = application:set_env(lager, error_logger_hwm_original, Val),
ok
end,
Expand Down