-
Notifications
You must be signed in to change notification settings - Fork 4k
rabbit_lager: Multiply high watermark by 100 when log level is debug #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rabbit_lager: Multiply high watermark by 100 when log level is debug #1912
Conversation
Otherwise debug messages are quickly dropped by Lager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this have an effect when the log level is debug from the start?
|
What do you think of 13f4117 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the node starts with debug level, it now uses the HWM value of 5000. That's fine.
If I then set log level to debug with
rabbitmqctl set_log_level debugthe value is bumped to 500K. Setting it to info after that with
rabbitmqctl set_log_level infosets the value back to 5000 instead of 50.
|
Hmm when I start the node with the log level set to @michaelklishin: how did you configure the initial log level? |
|
I see what @dumbbell describes. HWM is Config file is as follows: |
|
I start a node with |
|
It works as expected with an explicitly provided config. Could be something specific to my environment. |
…evel-is-debug rabbit_lager: Multiply high watermark by 100 when log level is debug (cherry picked from commit 5b2e000)
|
@michaelklishin I'm just now testing with |
|
False alarm, |
|
With this PR I suggest that rabbitmq/rabbitmq-common@c049442 is reverted. |
|
Thank you! I will take care of reverting the change in rabbitmq-common. |
|
The problem with the initial patch is that setting the log level from the configuration does not change the high watermark on startup if that level is set to |
... if the log level is set to `debug` in the configuration. This allows us to revert commit rabbitmq/rabbitmq-common@c04944235b. References #1912.
Otherwise debug messages are quickly dropped by Lager.