Skip to content

Always store the termdict indices in the hotcache. #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022
Merged

Always store the termdict indices in the hotcache. #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion quickwit-directories/src/hot_directory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,17 @@ pub fn write_hotcache<D: Directory>(
if let Some(intervals) = per_file_slices.get(&file_path) {
for byte_range in intervals {
let len = byte_range.len();
if file_path.to_string_lossy().ends_with("store") || len < 10_000_000 {
// We do not want to store slices that are too large in the hotcache,
// but on the other hand, the term dictionray index and the docstore
// index are required for quickwit to work.
//
// Warning: we need to work on string here because `Path::ends_with`
// has very different semantics.
let file_path_str = file_path.to_string_lossy();
if file_path_str.ends_with("store")
|| file_path_str.ends_with("term")
|| len < 10_000_000
{
let bytes = file_slice.read_bytes_slice(byte_range.clone())?;
file_cache_builder.add_bytes(bytes.as_slice(), byte_range.start);
}
Expand Down