Skip to content

Conversation

@fulmicoton
Copy link
Collaborator

@fulmicoton fulmicoton commented May 6, 2022

Always store the termdict indices in the hotcache.

Before it could be skipped if it was greater than 10mb,
but Quickwit does not work at all if it not there.

Such size was uncommon and due to a misconfiguration.
We are mitigating the size problem independently.

Closes #1366

I verified manually that the bug described in #1366 was sovled.

 cargo run --release  -- index search --index hackernews_5 --query "Ambulance"
    Finished release [optimized] target(s) in 0.27s
     Running `target/release/quickwit index search --index hackernews_5 --query Ambulance`
{
  "num_hits": 9,
  "hits": [
    {
      "id": 16203439,
      "text": "Be the real super hero not by the super powers but by the deeds that matter, save the life of the Civilians in the city in the most realistic Rescue Simulation Games of time, Ambulance Rescue & Helicopter Heroes.",
      "title": "Ambulance Rescue and Helicopter Heroes",
      "type": "story"
    },
    {

@fulmicoton fulmicoton force-pushed the issue/1366 branch 3 times, most recently from 620cf68 to dc8c9df Compare May 6, 2022 06:23
@fulmicoton fulmicoton requested a review from evanxg852000 May 6, 2022 06:27
@fulmicoton fulmicoton enabled auto-merge (squash) May 6, 2022 06:27
@fulmicoton fulmicoton changed the title Closes #1366 Always store the termdict indices in the hotcache. May 6, 2022
Before it could be skipped if it was greater than 10mb,
but Quickwit does not work at all if it not there.

Such size was uncommon and due to a misconfiguration.
We are mitigating the size problem independently.

Closes #1366
@fulmicoton fulmicoton merged commit 6bdfe4e into main May 6, 2022
@fulmicoton fulmicoton deleted the issue/1366 branch May 6, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in quickwit search stream StorageDirectory only supports async reads

3 participants