Expose det_order building in the python module
#65
+116
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync changes
latest changes
…-logic Expose detector order creation
LalehB
approved these changes
Aug 3, 2025
Collaborator
LalehB
left a comment
LalehB
left a comment
There was a problem hiding this comment.
LGTM!
Thank you Noah.
btw since the bfs ordering is by default on, is this mostly for the cases that we might want to turn it off?
| def test_build_det_orders_no_bfs(): | ||
| assert tesseract_decoder.utils.build_det_orders( | ||
| _DETECTOR_ERROR_MODEL, num_det_orders=1, det_order_bfs=False, seed=0 | ||
| ) == [[0, 1]] |
Collaborator
There was a problem hiding this comment.
It seems that for this DEM, with bfs and no bfs will have the same det_orders, right?
| if (det_order_bfs) { | ||
| auto graph = build_detector_graph(dem); | ||
| std::uniform_int_distribution<size_t> dist_det(0, graph.size() - 1); | ||
| for (size_t det_order = 0; det_order < num_det_orders; ++det_order) { |
Collaborator
There was a problem hiding this comment.
Thank you so much for moving the build_det_orders to the util folder! it makes more sense :-) maybe later we break this build_det_orders function into smaller helper functions such as generate_bfs_order and more.
This was referenced Aug 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--det-order-bfssignificantly improves the performance of tesseract for decoding e.g. color code circuit-level noisetesseract_main.cc