Create a visualization class and wire it through the code #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoureldinYosri
commented
Aug 9, 2025
| void Visualizer::add_activated_detectors(const boost::dynamic_bitset<>& detectors, | ||
| size_t num_detectors) { | ||
| std::stringstream ss; | ||
| ss << "activated_detectors = "; |
Contributor
Author
There was a problem hiding this comment.
@LalehB is it supposed to be activated_detectors or activated_dets ... the script seems to look for _dets
tesseract-decoder/viz/to_json.py
Line 49 in 0a7aa24
Collaborator
There was a problem hiding this comment.
@NoureldinYosri yeah amazing catch! it used to be activated_dets and then in the code got changed to activated_detectors but apparently the visualization did not get updated! thanks a lot!
LalehB
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently visualization is created by parsing the logs ... this PR introduces a different way to do this by creating a visualization class ... for now this class can only write to file to be inline with how things are done now but can be improved in different ways ... for example it can record data that the python layer can use directly with matplotlib
to use the class set the flag
create_visualization=Truein the TesseractConfig and after running the decoding calldecoder.visualizer.write(file_path)to write to the desired file