Tame progress bar #152
Merged
Tame progress bar #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steffengreiner
requested changes
Feb 20, 2023
Contributor
Steffengreiner
left a comment
Steffengreiner
left a comment
There was a problem hiding this comment.
Heya @KochTobi, First of all very nice work! The Progress Bar works as intended and is not jumpy anymore.
However i found a problem with the remove method which should be addressed before this can be merged
Co-authored-by: steffengreiner <[email protected]>
Merged
KochTobi
added a commit
that referenced
this pull request
Feb 20, 2023
* Added version information option (#139) * Added version information option * Rename variables --------- Co-authored-by: Tobias Koch <[email protected]> * Require commons-codec version >= 1.13 (#149) * [DEPENDABOT]: Bump groovy from 2.5.1 to 3.0.9 (#85) Bumps [groovy](https://github.com/apache/groovy) from 2.5.1 to 3.0.9. - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) --- updated-dependencies: - dependency-name: org.codehaus.groovy:groovy:indy dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update JavaDoc (#138) * edited & added Javadocs * very small refactor * Update branch --------- Co-authored-by: Tobias Koch <[email protected]> * Fix log folder not created reliably (#151) * Tame progress bar (#152) * Tame progress bar * Incorporate feedback Co-authored-by: steffengreiner <[email protected]> * Initialize last updated with 0 * Fix small error * simplify console output * make update interval constant --------- Co-authored-by: steffengreiner <[email protected]> * Update README.md --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Aline Breitinger <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: steffengreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits a re-render of the progress bar to once a second (except for when a step is added)