Skip to content

Conversation

@Aline-9
Copy link
Collaborator

@Aline-9 Aline-9 commented Oct 26, 2022

$java -jar postman-cli.jar --version
version: 1.3.0
JVM: 1.8.0_265 (Eclipse OpenJ9 Eclipse OpenJ9 VM openj9-0.21.0)
OS: Mac OS X 10.16 x86_64

@Aline-9 Aline-9 requested a review from KochTobi October 26, 2022 13:56
@Aline-9 Aline-9 requested a review from a team as a code owner October 26, 2022 13:56
@Aline-9
Copy link
Collaborator Author

Aline-9 commented Oct 26, 2022

Version still has to be changed in the pom and the name of the .jar file. I was wondering if you know of a possibility to maybe change the name or if this would make sense even?

Copy link
Contributor

@KochTobi KochTobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very nice job.
I think it is ok to not list the name.

@KochTobi KochTobi merged commit 4f066a9 into development Feb 17, 2023
@KochTobi KochTobi deleted the feature/versionInformation branch February 17, 2023 12:20
@KochTobi KochTobi mentioned this pull request Feb 20, 2023
KochTobi added a commit that referenced this pull request Feb 20, 2023
* Added version information option (#139)

* Added version information option

* Rename variables

---------

Co-authored-by: Tobias Koch <[email protected]>

* Require commons-codec version >= 1.13 (#149)

* [DEPENDABOT]: Bump groovy from 2.5.1 to 3.0.9 (#85)

Bumps [groovy](https://github.com/apache/groovy) from 2.5.1 to 3.0.9.
- [Release notes](https://github.com/apache/groovy/releases)
- [Commits](https://github.com/apache/groovy/commits)

---
updated-dependencies:
- dependency-name: org.codehaus.groovy:groovy:indy
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update JavaDoc (#138)

* edited & added Javadocs

* very small refactor

* Update branch

---------

Co-authored-by: Tobias Koch <[email protected]>

* Fix log folder not created reliably (#151)

* Tame progress bar (#152)

* Tame progress bar

* Incorporate feedback

Co-authored-by: steffengreiner <[email protected]>

* Initialize last updated with 0

* Fix small error

* simplify console output

* make update interval constant

---------

Co-authored-by: steffengreiner <[email protected]>

* Update README.md

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Aline Breitinger <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: steffengreiner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants