Skip to content

Pin setuptools to 58.0.4 on Widnows #5868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2022
Merged

Pin setuptools to 58.0.4 on Widnows #5868

merged 1 commit into from
Apr 24, 2022

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Apr 22, 2022

setuptools were update on anaconda to 61.2.0 10 days ago, but CircleCI environment caching occluded the issue for a while, but when update happened Win+Python-3.7 build started to fail, which suggests that it might have been caused by pypa/setuptools#3219

Fixes #5830

Not sure what changed in 61.2.0, but it causes build failures
@malfet
Copy link
Contributor Author

malfet commented Apr 24, 2022

Going to merge it as is, but feel free to revert (or refine the statement to apply only to py-3.7 config

@malfet malfet merged commit e99278a into main Apr 24, 2022
@github-actions
Copy link

Hey @malfet!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@datumbox datumbox deleted the malfet-patch-1 branch April 25, 2022 08:31
@datumbox datumbox added the other if you have no clue or if you will manually handle the PR in the release notes label Apr 25, 2022
@datumbox
Copy link
Contributor

@malfet LGTM. Unfortunately we can't test this because our CI is completely broken (seems unrelated, caused by upstream changes; documented at #5873). I'll confirm this works once the other issue is resolved. Thanks for the help.

facebook-github-bot pushed a commit that referenced this pull request May 6, 2022
Summary: Not sure what changed in 61.2.0, but it causes build failures

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095698

fbshipit-source-id: 9e34f6805f75f9a2d11195b0ee9e9a273f6dff88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed module: ci other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: can't copy 'build\lib.win-amd64-3.7\pyd': doesn't exist or not a regular file
3 participants