Skip to content

Add Phi4 test and fix regex parsing. #14716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

Add Phi4 test and fix regex parsing. #14716

merged 1 commit into from
Oct 3, 2025
+59 −6

Conversation

shoumikhin
Copy link
Contributor

Summary:

  • Add Phi4 test
  • Handle the invert flag properly
  • Skip regex lookahead since it's not supported by RE2
  • Catch std::exception instead of narrow json parser errors
  • Make the special tokens arg optional in ObjC/Swift API

Differential Revision: D83641294

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14716

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 30256b4 with merge base 54bfd72 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2025
@facebook-github-bot
Copy link
Contributor

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83641294.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

shoumikhin added a commit to shoumikhin/tokenizers that referenced this pull request Oct 2, 2025
@shoumikhin @facebook-github-bot
Add Phi4 test and fix regex parsing. (meta-pytorch#130)
b0eb807 
Summary:
X-link: pytorch/executorch#14716


- Add Phi4 test
- Handle the invert flag properly
- Skip regex lookahead since it's not supported by RE2
- Catch std::exception instead of narrow json parser errors
- Make the special tokens arg optional in ObjC/Swift API

Reviewed By: metascroy

Differential Revision: D83641294
larryliu0820
larryliu0820 approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

shoumikhin added a commit to shoumikhin/tokenizers that referenced this pull request Oct 3, 2025
@shoumikhin @facebook-github-bot
Add Phi4 test and fix regex parsing. (meta-pytorch#130)
e7e0973 
Summary:
X-link: pytorch/executorch#14716


- Add Phi4 test
- Handle the invert flag properly
- Skip regex lookahead since it's not supported by RE2
- Catch std::exception instead of narrow json parser errors
- Make the special tokens arg optional in ObjC/Swift API

Reviewed By: larryliu0820, metascroy

Differential Revision: D83641294
@shoumikhin @facebook-github-bot
Add Phi4 test and fix regex parsing. (pytorch#14716)
30256b4 
Summary:

X-link: meta-pytorch/tokenizers#130

- Add Phi4 test
- Handle the invert flag properly
- Skip regex lookahead since it's not supported by RE2
- Catch std::exception instead of narrow json parser errors
- Make the special tokens arg optional in ObjC/Swift API

Reviewed By: larryliu0820, metascroy

Differential Revision: D83641294
@facebook-github-bot facebook-github-bot merged commit 70ea661 into pytorch:main Oct 3, 2025
128 of 133 checks passed
@shoumikhin
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/1.0 -c fixnewfeature

pytorchbot pushed a commit that referenced this pull request Oct 6, 2025
@shoumikhin @pytorchbot
Add Phi4 test and fix regex parsing.
6b5e08d 
Differential Revision: D83641294

Pull Request resolved: #14716

(cherry picked from commit 70ea661)
@pytorchbot
Copy link
Collaborator

Cherry picking #14716

The cherry pick PR is at #14821 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin approved these changes

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shoumikhin @facebook-github-bot @pytorchbot @mergennachin @larryliu0820