Add Phi4 test and fix regex parsing. #130
Merged
+68
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83641294. |
shoumikhin
added a commit
to shoumikhin/tokenizers
that referenced
this pull request
Oct 2, 2025
Summary: X-link: pytorch/executorch#14716 - Add Phi4 test - Handle the invert flag properly - Skip regex lookahead since it's not supported by RE2 - Catch std::exception instead of narrow json parser errors - Make the special tokens arg optional in ObjC/Swift API Reviewed By: metascroy Differential Revision: D83641294
shoumikhin
force-pushed
the
export-D83641294
branch
from
bbcf76d to
b0eb807
Compare
larryliu0820
approved these changes
Oct 2, 2025
Summary: X-link: pytorch/executorch#14716 - Add Phi4 test - Handle the invert flag properly - Skip regex lookahead since it's not supported by RE2 - Catch std::exception instead of narrow json parser errors - Make the special tokens arg optional in ObjC/Swift API Reviewed By: larryliu0820, metascroy Differential Revision: D83641294
shoumikhin
force-pushed
the
export-D83641294
branch
from
b0eb807 to
e7e0973
Compare
shoumikhin
added a commit
to shoumikhin/executorch
that referenced
this pull request
Oct 3, 2025
Summary: X-link: meta-pytorch/tokenizers#130 - Add Phi4 test - Handle the invert flag properly - Skip regex lookahead since it's not supported by RE2 - Catch std::exception instead of narrow json parser errors - Make the special tokens arg optional in ObjC/Swift API Reviewed By: larryliu0820, metascroy Differential Revision: D83641294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D83641294