Add vectorized_math.h #11204
Open
Add vectorized_math.h #11204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
swolchok
requested review from
jathu,
larryliu0820,
kirklandsign,
JacobSzwejbka,
lucylq and
manuelcandales
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11204
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 402caf2 with merge base 71025df ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced May 28, 2025
[ghstack-poisoned]
This was referenced May 28, 2025
[ghstack-poisoned]
|
|
||
| TEST(VectorizedMathTest, BasicUnary) { | ||
| __at_align__ float result_floats[at::vec::Vectorized<float>::size()] = {0}; | ||
| const auto x_vec = at::vec::Vectorized<float>::arange(0, 1); |
There was a problem hiding this comment.
why are all these tests using arange(0, 1), i.e. a single number instead of an actual vector of numbers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set of math functions that work on both scalars and at::vec::Vectorized, to be used in #9432.