-
Notifications
You must be signed in to change notification settings - Fork 564
Add SupportedTensorDtypes::BOOL #9584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/swolchok/396/head
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9584
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 6e71130 with merge base 71025df ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -23,10 +23,14 @@ bool check_tensor_dtype( | |||
return executorch::runtime::tensor_is_realhbbf16_type(t); | |||
case SupportedTensorDtypes::REALHBF16: | |||
return executorch::runtime::tensor_is_realhbf16_type(t); | |||
case SupportedTensorDtypes::REALH: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the h in realh? half?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it matches the naming scheme in
#define ET_SWITCH_REALH_TYPES(TYPE, CONTEXT, NAME, CTYPE_ALIAS, ...) \ |
probably we want to skip adding REALH and just replace it with REALHBF16 in subseqeuent diffs |
This PR needs a
|
[ghstack-poisoned]
No description provided.