Skip to content

Add SupportedTensorDtypes::BOOL #9584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: gh/swolchok/396/head
Choose a base branch
from
Open

Add SupportedTensorDtypes::BOOL #9584

wants to merge 2 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 25, 2025 •
edited
Loading

No description provided.

@swolchok swolchok requested a review from GregoryComer as a code owner March 25, 2025 17:05
@swolchok
Copy link
Contributor Author

swolchok commented Mar 25, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9584

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Unrelated Failures

As of commit 6e71130 with merge base 71025df (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 25, 2025
This was referenced Mar 25, 2025
Merged
Closed
Merged
Merged
Merged
Open
Open
Closed
@swolchok swolchok removed the request for review from digantdesai March 25, 2025 17:08
JacobSzwejbka
JacobSzwejbka reviewed Mar 25, 2025
View reviewed changes
kernels/portable/cpu/util/dtype_util.cpp Outdated
@@ -23,10 +23,14 @@ bool check_tensor_dtype(
return executorch::runtime::tensor_is_realhbbf16_type(t);
case SupportedTensorDtypes::REALHBF16:
return executorch::runtime::tensor_is_realhbf16_type(t);
case SupportedTensorDtypes::REALH:
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka Mar 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the h in realh? half?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it matches the naming scheme in

executorch/runtime/core/exec_aten/util/scalar_type_util.h

Line 1189 in 644b7dd

#define ET_SWITCH_REALH_TYPES(TYPE, CONTEXT, NAME, CTYPE_ALIAS, ...) \

@swolchok swolchok temporarily deployed to upload-benchmark-results March 25, 2025 17:22 — with GitHub Actions Inactive
@swolchok swolchok temporarily deployed to upload-benchmark-results March 25, 2025 17:26 — with GitHub Actions Inactive
@swolchok swolchok changed the base branch from gh/swolchok/386/head to gh/swolchok/382/head March 25, 2025 18:12
@swolchok
Copy link
Contributor Author

probably we want to skip adding REALH and just replace it with REALHBF16 in subseqeuent diffs

Base automatically changed from gh/swolchok/382/head to main April 22, 2025 23:17
@swolchok
Update
17e45db 
[ghstack-poisoned]
@swolchok swolchok requested a review from jathu as a code owner May 28, 2025 23:57
This was referenced May 28, 2025
Open
Open
@swolchok swolchok changed the base branch from main to gh/swolchok/396/head May 28, 2025 23:57
This was referenced May 28, 2025
Open
Open
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:.

If not, please add the release notes: none label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok swolchok added the release notes: none Do not include this in the release notes label May 28, 2025
@swolchok swolchok changed the title Add SupportedTensorDtypes::{BOOL,REALH} Add SupportedTensorDtypes::BOOL May 29, 2025
@swolchok
rebase, fix lint in #9432
6e71130 
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@manuelcandales manuelcandales manuelcandales approved these changes

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

@jathu jathu Awaiting requested review from jathu

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swolchok @JacobSzwejbka @manuelcandales @facebook-github-bot