Skip to content

broadcast the two input shapes for transposed matmul #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022
Merged

broadcast the two input shapes for transposed matmul #1457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions py/torch_tensorrt/fx/converters/acc_ops_converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ def trt_transposed_matmul_converter(network, target, args, kwargs, name):
lhs = get_trt_tensor(network, lhs, f"{name}_lhs")
if isinstance(rhs, torch.nn.Parameter):
rhs = get_trt_tensor(network, rhs, f"{name}_rhs")

lhs, rhs = broadcast(
network,
lhs,
rhs,
f"{lhs.name}_broadcast",
f"{rhs.name}_broadcast",
)
layer = network.add_matrix_multiply(
lhs,
trt.MatrixOperation.TRANSPOSE if lhs_transposed else trt.MatrixOperation.NONE,
Expand Down
3 changes: 3 additions & 0 deletions py/torch_tensorrt/fx/test/passes/test_fuse_permute_matmul_trt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ class TestFusePermuteMatmul(AccTestCase):
lambda x: x.permute(0, 1, 3, 2),
torch.matmul,
),
param("transpose_lhs_bmm_broadcast", (3, 2), (3, 3, 4), tranpose_last_two_dims, op=torch.matmul),
param("transpose_rhs_bmm_broadcast", (3, 3, 4), (3, 4), rhs_op=tranpose_last_two_dims, op=torch.matmul),
]
)
def test_fuse_permute_matmul(
Expand All @@ -58,6 +60,7 @@ def forward(self, x, y):
inputs,
{trt_transposed_matmul},
apply_passes=[fuse_permute_matmul],
test_implicit_batch_dim=(len(lhs_shape) == len(rhs_shape)),
)

@parameterized.expand(
Expand Down