Skip to content

broadcast the two input shapes for transposed matmul #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2022
Merged

broadcast the two input shapes for transposed matmul #1457

merged 1 commit into from
Dec 6, 2022

Conversation

nvpohanh
Copy link
Contributor 

modified:   py/torch_tensorrt/fx/converters/acc_ops_converters.py
modified:   py/torch_tensorrt/fx/test/passes/test_fuse_permute_matmul_trt.py

Description

This is identical to #1413 , but I will do this for @FelixXidddd

@narendasan
Copy link
Collaborator

@frank-wei can you take a look at this PR?

@narendasan
Copy link
Collaborator

Also @nvpohanh Can you run pre-commit to lint the code?

frank-wei
frank-wei approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@frank-wei frank-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this patch. LGTM!

@xxi-nv
Copy link

xxi-nv commented Nov 21, 2022 •
edited
Loading

@nvpohanh could you pull from #1413 again, I have just reformatted the test file using black[jupyter].
Or you could do this by :
1 - pip install black[jupyter]
2 -python3 -m black py/torch_tensorrt/fx/test/passes/test_fuse_permute_matmul_trt.py

@nvpohanh nvpohanh force-pushed the addBroadCastToTransposeMatmul branch 2 times, most recently from 69d371f to 6f3d7e9 Compare November 22, 2022 10:09
@nvpohanh nvpohanh mentioned this pull request Nov 22, 2022
Closed
7 tasks
@yinghai
Copy link

yinghai commented Nov 22, 2022

Looks like our CI is all broken due torch version deps?

@nvpohanh nvpohanh force-pushed the addBroadCastToTransposeMatmul branch from 6f3d7e9 to 75b445b Compare December 5, 2022 07:20
@yinghai yinghai merged commit 4937097 into pytorch:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frank-wei frank-wei frank-wei approved these changes

@842974287 842974287 Awaiting requested review from 842974287

@narendasan narendasan Awaiting requested review from narendasan

@wushirong wushirong Awaiting requested review from wushirong

@yinghai yinghai Awaiting requested review from yinghai

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: fx fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nvpohanh @narendasan @xxi-nv @yinghai @frank-wei @facebook-github-bot