Skip to content

Fix import sorting in create_baseline_stubs script #5781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 2 commits into from
Jul 15, 2021
Merged

Fix import sorting in create_baseline_stubs script #5781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3944705
Fix import sorting in create_baseline_stubs script
JukkaL Jul 15, 2021
b282477
Better fix
JukkaL Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/create_baseline_stubs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ def run_black(stub_dir: str) -> None:


def run_isort(stub_dir: str) -> None:
print(f"Running isort: isort --recursive {stub_dir}")
subprocess.run(["isort", "--recursive", stub_dir])
print(f"Running isort: isort {stub_dir}")
subprocess.run(["python3", "-m", "isort", stub_dir])


def create_metadata(stub_dir: str, version: str) -> None:
Expand Down Expand Up @@ -150,8 +150,8 @@ def main() -> None:
# Stubs were generated under out/. Copy them to stubs/.
copy_stubs("out", package, stub_dir)

run_black(stub_dir)
run_isort(stub_dir)
run_black(stub_dir)

create_metadata(stub_dir, version)

Expand Down