Skip to content

Conversation

@JukkaL
Copy link
Contributor

@JukkaL JukkaL commented Jul 15, 2021

The isort --recursive option doesn't recognize .pyi files, so find all
.pyi files explicitly.

Run isort before black since changes made by isort don't follow stub
conventions.

The isort `--recursive` option doesn't recognize `.pyi` files, so fine all
`.pyi` files explicitly.

Run isort before black since changes made by isort don't follow stub
conventions.
@srittau
Copy link
Collaborator

srittau commented Jul 15, 2021

I always run isort on the stub dir itself, without the --recursive option, which isn't required since isort 5. I would try that first.

@JukkaL
Copy link
Contributor Author

JukkaL commented Jul 15, 2021

It turns that the problem was that for some reason isort runs a pre-5 version for me. I still don't quite understand what is going on. I'm going to update this to use python3 -m isort, since it works for me.

@srittau srittau merged commit b3b8dae into python:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants