Run tests on win32 for mypy #3425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
force-pushed
the
windowstest
branch
from
9ac7577 to
39164fa
Compare
|
Could we maybe just run one of the mypy tests (not the self test) using the windows and darwin platform using travis-ci as separate jobs? This would run in parallel to the other tests. |
|
#3457 is merged now and is a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed an issue in Windows (see #3424) because typeshed tests run only on Unix; it was caught in mypy tests because those also run on Windows. This PR makes the typeshed mypy test also run with
--platform win32.I'm not quite sure this is worth it because it will double testing time and it's been very rare for a Windows-only mypy issue to get missed. We also have a handful of sys.platform checks for "darwin" in typeshed, so perhaps we should also add that to the tested platforms, but that would increase testing time even more.