-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Running mypy on typeshed checkout on Widows results in errors #3446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The second error makes sense, but I wonder why the first error is not flagged on other systems. There seems to be nothing Windows-specific about it. Both look easy to fix, though. |
#3425 should address this (at least the CI part of it). |
This may indicate some bug in the test suite. Currently mypy test contains deeply nested cycles, I am wondering maybe there is some "indentation error" causing some files not being checked? |
It might be a similar issue to what I fixed in #3424, where an |
Hm, it looks like this starts causing troubles in mypy, see CI failure in python/mypy#7794, I will make a PR now. |
Fix errors discovered by running typeshed check on Windows. This is a temporary fix for #3446 (in long term we should figure out why these were not caught by typeshed CI). I also remove an outdated comment while I am at it.
I think this can be closed now as both relevant PRs were merged. |
I just tried checking typeshed with mypy on Windows and I get:
Not a big deal, but maybe we should fix these errors.
The text was updated successfully, but these errors were encountered: