Skip to content

add note about not squashing #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2018
Merged

add note about not squashing #1830

merged 1 commit into from
Jan 17, 2018

Conversation

elliott-beach
Copy link
Contributor

@elliott-beach elliott-beach commented Jan 17, 2018 •
edited
Loading

Follow up on python/mypy#4470

although maybe this should be more prominently displayed, because it seems to come up a lot?

gvanrossum
gvanrossum approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well only once per contributor. :-)

I don't know how to get people to read docs...

@gvanrossum gvanrossum merged commit f207bc3 into python:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliott-beach @gvanrossum