Add note about not squashing #4470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Jan 16, 2018
CONTRIBUTING.md
Outdated
| @@ -109,6 +109,9 @@ which consist mainly of a reference to | |||
| [PEP 8](https://www.python.org/dev/peps/pep-0008/) -- for the code you | |||
| put in the pull request. | |||
|
|
|||
| Also, do not squash your commits after you have submitted a pull request, as this | |||
| erases context during review. We can squash commits when the pull request is merged. | |||
There was a problem hiding this comment.
I'd say "We will squash ..." (don't put in the emphasis).
|
Thanks! Did you submit a PR for typeshed too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4161.
Nickatak asked about this in python/typing#527, and we might as well fix it.
I can open a PR in typing after this is merged.