Skip to content

Remove subclass IOBase from TextIOBase. #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2017
Merged

Remove subclass IOBase from TextIOBase. #1505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49e1220
Remove subclass IOBase from TextIOBase.
matthiaskramm Jul 28, 2017
ea063e3
Fix fcntl to use IO instead of IOBase.
matthiaskramm Jul 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/2/fcntl.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Any, Union
from typing import Any, Union, IO
import io

FASYNC = ... # type: int
Expand Down Expand Up @@ -72,7 +72,7 @@ LOCK_SH = ... # type: int
LOCK_UN = ... # type: int
LOCK_WRITE = ... # type: int

_ANYFILE = Union[int, io.IOBase]
_ANYFILE = Union[int, IO]

# TODO All these return either int or bytes depending on the value of
# cmd (not on the type of arg).
Expand Down
4 changes: 3 additions & 1 deletion stdlib/2/io.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,7 @@ class RawIOBase(_io._RawIOBase, IOBase):
class BufferedIOBase(_io._BufferedIOBase, IOBase):
pass

class TextIOBase(_io._TextIOBase, IOBase): # type: ignore
# Note: In the actual io.py, TextIOBase subclasses IOBase.
# (Which we don't do here because we don't want to subclass both TextIO and BinaryIO.)
class TextIOBase(_io._TextIOBase):
pass