Skip to content

Remove subclass IOBase from TextIOBase. #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2017
Merged

Remove subclass IOBase from TextIOBase. #1505

merged 2 commits into from
Jul 29, 2017

Conversation

matthiaskramm
Copy link
Contributor

This used to cause TextIOBase to subclass both BinaryIO and TextIO, even
though those two are incompatible.

@matthiaskramm
Remove subclass IOBase from TextIOBase.
49e1220 
This used to cause TextIOBase to subclass both BinaryIO and TextIO, even
though those two are incompatible.
@matthiaskramm
Fix fcntl to use IO instead of IOBase.
ea063e3
@matthiaskramm
Copy link
Contributor Author

matthiaskramm commented Jul 28, 2017 •
edited
Loading

Also fixed fcntl.pyi to use IO instead of IOBase.
E.g. fcntl.fcntl() works for files (as in: the return value of open()), but files are not instances of IOBase.

gvanrossum
gvanrossum approved these changes Jul 29, 2017
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't we think of this before?

(I'll merge once internal tests pass.)

@gvanrossum gvanrossum merged commit 6f23d12 into master Jul 29, 2017
@gvanrossum gvanrossum deleted the io branch July 29, 2017 04:07
@EvanKrall EvanKrall mentioned this pull request Aug 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiaskramm @gvanrossum