Fix infinite loop on corrupted fine-grained cache #5739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hit me when mypyc was causing crashes after having written out part of the cache, but subsequent runs would instead infinite loop.
ilevkivskyi
approved these changes
Oct 4, 2018
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Good catch!
It would be great to add a test case for this, but it is probably non-trivial. Maybe add a comment in #5002, so we not forget about this?
Member
|
I think I may have hit this yesterday. I did something with dmypy like the following:
The daemon was started with |
Member
|
Should probably be merged before I cut the release branch (#5741). |
gvanrossum
approved these changes
Oct 5, 2018
Collaborator
Author
|
Turns out that we already had a test case for the case where the cache file was wrong, but we only infinite loop when it is missing. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hit me when mypyc was causing crashes after having written out
part of the cache, but subsequent runs would instead infinite loop.