Skip to content

Fix infinite loop on corrupted fine-grained cache #5739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Fix infinite loop on corrupted fine-grained cache #5739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeeef1d
Fix infinite loop on corrupted fine-grained cache
msullivan Oct 4, 2018
180e516
Add a test
msullivan Oct 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mypy/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2145,6 +2145,8 @@ def dispatch(sources: List[BuildSource], manager: BuildManager) -> Graph:
if proto_deps is not None:
TypeState.proto_deps = proto_deps
elif manager.stats.get('fresh_metas', 0) > 0:
# Clear the stats so we don't infinite loop because of positive fresh_metas
manager.stats.clear()
# There were some cache files read, but no protocol dependencies loaded.
manager.log("Error reading protocol dependencies cache -- aborting cache load")
manager.cache_enabled = False
Expand Down
15 changes: 15 additions & 0 deletions test-data/unit/check-incremental.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4350,6 +4350,21 @@ import b
[stale a, b, builtins]
[rechecked a, b, builtins]

[case testIncrementalBustedFineGrainedCache3]
# flags: --cache-fine-grained
import a
import b
[file a.py]
[file b.py]
-- This is a heinous hack, but we simulate having a invalid cache by deleting
-- the proto deps file.
[delete ../.mypy_cache/3.6/@proto_deps.meta.json.2]
[file b.py.2]
# uh
-- Every file should get reloaded, since the cache was invalidated
[stale a, b, builtins]
[rechecked a, b, builtins]

[case testIncrementalWorkingFineGrainedCache]
# flags: --cache-fine-grained
# flags2: --cache-fine-grained
Expand Down