Optimize the computation of lib_path #4982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main thing is to compute base library directories while finding sources, since we already have a cache to avoid duplicated file-system traversal work there. Also eliminate some unnecessarily quadratic stuff.
I don't think it does anything useful anymore?
JukkaL
approved these changes
Apr 27, 2018
msullivan
added a commit
that referenced
this pull request
Apr 27, 2018
This reverts commit 991edf2.
msullivan
added a commit
that referenced
this pull request
Apr 27, 2018
The main thing is to compute base library directories while finding sources, since we already have a cache to avoid duplicated file-system traversal work there. Also eliminate some unnecessarily quadratic stuff. Also get rid of remove_cwd_prefix_from_path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thing is to compute base library directories while finding
sources, since we already have a cache to avoid duplicated file-system
traversal work there. Also eliminate some unnecessarily quadratic
stuff.
Follow up to #4981. This might have been one PR, but I'd like to cherry-pick just the original correctness patch.