Recompute lib_path on every fine-grained incremental run #4981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some crashes and false positives when creating or removing __init__.py files that do not appear in the build. This just factors out the existing implementation of lib_path computation and reuses it. It is somewhat inefficient and should be improved on if we are going to call it on every fine-grained update.
JukkaL
approved these changes
Apr 27, 2018
msullivan
added a commit
that referenced
this pull request
Apr 27, 2018
This fixes some crashes and false positives when creating or removing __init__.py files that do not appear in the build. This just factors out the existing implementation of lib_path computation and reuses it. It is somewhat inefficient and should be improved on if we are going to call it on every fine-grained update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some crashes and false positives when creating or removing
init.py files that do not appear in the build.
This just factors out the existing implementation of lib_path
computation and reuses it. It is somewhat inefficient and should be
improved on if we are going to call it on every fine-grained update.
I would like to cherry-pick this into 0.600 (#4946).
There is going to be a follow up PR immediately that optimizes the
lib_pathrecomputation, but the case for cherry-picking that is a lot harder to make than for just a straightforward bug fix.The cost of recomputing every time is about ~125ms on S.