Skip to content

Conversation

pkch
Copy link
Contributor

@pkch pkch commented Apr 24, 2017

Is it worth printing version number on INTERNAL ERROR? If so, we can use this small patch to do so.

I also added INTERNAL ERROR output at the outer level (mypy.main) in case we don't catch it inside; it happened for example in #3232.

@gvanrossum
Copy link
Member

I like the idea of printing the version on internal errors. I do not like the complexity of calling report_internal_error() from the main script.

@pkch pkch closed this Apr 25, 2017
@pkch
Copy link
Contributor Author

pkch commented Apr 25, 2017

I just push --force a simpler commit that just prints mypy version, and doesn't do anything else. Didn't mean to close it, I think it's some weird github logic :)

Edit: nm, I forgot to commit and so push --force the current master haha

@pkch pkch reopened this Apr 25, 2017
@gvanrossum gvanrossum merged commit 65b9b0b into python:master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants