-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New incremental mode (-i) crasher #3232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Oh, I'll also check if the user who reported this had a sufficiently recent mypy version. |
[UPDATE: I was wrong there] |
Unfortunately, this is the recent version (after my fix). I can see from the line numbers. Is there any information about the crash (command line, whether it's intermittent, warm/cold cache, etc)? |
Well, actually the user reported they got the crash after upgrading to mypy 1d1c62d (and they have the Terminal window logs to prove it to me :-) so I'm afraid I need to reopen this. Sorry for the quick cycling. |
The user also reported: It [mypy -i] worked the first two times, then he added |
Maybe also important, we have a script that computes the list of files to pass to mypy, and the offending Also, we run with |
Also important: Python 2 mode! |
This is the key I think. |
@pkch maybe the solution is just to skip the reverse renaming in the PY2 mode? |
Yup, python 2 doesn't use |
Do you have time to make a fix? |
Yes. I can't reproduce the crash, but I'm pretty sure what @ilevkivskyi said is sufficient. If it still crashes, we'll just have to look further. |
Please send a PR -- I have a repro but I can't publish it, so I'll test your PR against it once I have it. |
I used the simplest fix I could (just check that |
Uh oh!
There was an error while loading. Please reload this page.
I've seen this a few times myself and now it's being reported. The traceback ends with
The text was updated successfully, but these errors were encountered: