Skip to content

Underscores in numeric literals #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2016
Merged

Conversation

ilevkivskyi
Copy link
Member

@ilevkivskyi ilevkivskyi commented Oct 22, 2016

There is a PR for implementation of underscores in numeric literals python/typed_ast#21

Here is the mypy counterpart (essentially just an error if used with Python 3.5 or less).
Until the typed_ast PR is merged and published on PyPI, this PR will have no effect (but no problems as well).

@gvanrossum @ddfisher Please, take a look.

@codecov-io
Copy link

codecov-io commented Oct 22, 2016

Current coverage is 83.53% (diff: 71.42%)

Merging #2303 into master will increase coverage by 0.43%

@@             master      #2303   diff @@
==========================================
  Files            72         72          
  Lines         19013      18988    -25   
  Methods           0          0          
  Messages          0          0          
  Branches       3909       3928    +19   
==========================================
+ Hits          15799      15861    +62   
+ Misses         2616       2530    -86   
+ Partials        598        597     -1   

Powered by Codecov. Last update 2e19181...89abf91

@gvanrossum
Copy link
Member

LGTM except for the typo in the error message. (@ddfisher when do you think the typed_ast fix can be merged?)

@gvanrossum gvanrossum merged commit 7d5e3ca into python:master Oct 25, 2016
@gvanrossum
Copy link
Member

gvanrossum commented Oct 25, 2016

We should also update the docs, esp. docs/source/python36.rst. (And note that this doesn't do anything until typed_ast is also updated, i.e. python/typed_ast#21 is merged.)

@ilevkivskyi
Copy link
Member Author

@gvanrossum
Here is a PR with short documentation #2336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants