Underscores in numeric literals (#2303)

Author: ilevkivskyi

mypy/fastparse.py

@@ -736,6 +736,9 @@ def is_star2arg(k: ast35.keyword) -> bool:
     # Num(object n) -- a number as a PyObject.
     @with_line
     def visit_Num(self, n: ast35.Num) -> Union[IntExpr, FloatExpr, ComplexExpr]:
+        if getattr(n, 'underscores', None) and self.pyversion < (3, 6):
+            raise FastParserError('Underscores in numeric literals are only '
+                                  'supported in Python 3.6', n.lineno, n.col_offset)
         if isinstance(n.n, int):
             return IntExpr(n.n)
         elif isinstance(n.n, float):
@@ -907,3 +910,7 @@ def __init__(self, msg: str, lineno: int, offset: int) -> None:
         self.msg = msg
         self.lineno = lineno
         self.offset = offset
+
+
+class FastParserError(TypeCommentParseError):
+    pass

mypy/test/testcheck.py

@@ -73,6 +73,9 @@
 if 'annotation' in typed_ast.ast35.Assign._fields:
     files.append('check-newsyntax.test')
 
+if 'underscores' in typed_ast.ast35.Num._fields:
+    files.append('check-underscores.test')
+
 
 class TypeCheckSuite(DataSuite):
     def __init__(self, *, update_data=False):

test-data/unit/check-underscores.test

@@ -0,0 +1,15 @@
+[case testUnderscoresRequire36]
+# flags: --fast-parser --python-version 3.5
+x = 1000_000  # E: Underscores in numeric literals are only supported in Python 3.6
+[out]
+
+[case testUnderscoresSyntaxError]
+# flags: --fast-parser --python-version 3.6
+x = 1000_000_  # E: invalid token
+[out]
+
+[case testUnderscoresBasics]
+# flags: --fast-parser --python-version 3.6
+x: int
+x = 1000_000
+y: str = 1000_000.000_001  # E: Incompatible types in assignment (expression has type "float", variable has type "str")