Skip to content

Use double quotes errors 'is not defined' and 'Cannot instantiate' #10278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2021

Conversation

dixith
Copy link
Contributor

@dixith dixith commented Apr 4, 2021

Description

This pull request fixes issue reported in #7445 for is not defined and Cannot instantiate error message

Test Plan

Updated test cases for the message. New test cases not added.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2021

Diff from mypy_primer, showing the effect of this PR on open source code:

SinbadCogs (https://github.com/mikeshardmind/SinbadCogs.git)
- channelredirect/redirect.py:180: error: Name 'to_store' is not defined
+ channelredirect/redirect.py:180: error: Name "to_store" is not defined


manticore (https://github.com/trailofbits/manticore.git)
- tests/auto_generators/make_dump.py:204: error: Name 'CS_ARCH_X86' is not defined
+ tests/auto_generators/make_dump.py:204: error: Name "CS_ARCH_X86" is not defined
- tests/auto_generators/make_dump.py:205: error: Name 'CS_MODE_32' is not defined
+ tests/auto_generators/make_dump.py:205: error: Name "CS_MODE_32" is not defined
- tests/auto_generators/make_dump.py:205: error: Name 'CS_MODE_64' is not defined
+ tests/auto_generators/make_dump.py:205: error: Name "CS_MODE_64" is not defined
- tests/auto_generators/make_dump.py:206: error: Name 'Cs' is not defined
+ tests/auto_generators/make_dump.py:206: error: Name "Cs" is not defined
- tests/auto_generators/make_dump.py:251: error: Name 'B' is not defined
+ tests/auto_generators/make_dump.py:251: error: Name "B" is not defined
- tests/auto_generators/make_dump.py:252: error: Name 'B' is not defined
+ tests/auto_generators/make_dump.py:252: error: Name "B" is not defined
- tests/auto_generators/make_dump.py:256: error: Name 'X86_OP_MEM' is not defined
+ tests/auto_generators/make_dump.py:256: error: Name "X86_OP_MEM" is not defined
- tests/auto_generators/make_dump.py:271: error: Name 'X86_OP_IMM' is not defined
+ tests/auto_generators/make_dump.py:271: error: Name "X86_OP_IMM" is not defined
- tests/auto_generators/make_dump.py:273: error: Name 'X86_OP_REG' is not defined
+ tests/auto_generators/make_dump.py:273: error: Name "X86_OP_REG" is not defined
- tests/auto_generators/make_dump.py:313: error: Name 'X86_REG_AH' is not defined
+ tests/auto_generators/make_dump.py:313: error: Name "X86_REG_AH" is not defined
- tests/auto_generators/make_dump.py:313: error: Name 'X86_REG_AX' is not defined
+ tests/auto_generators/make_dump.py:313: error: Name "X86_REG_AX" is not defined
- tests/auto_generators/make_dump.py:314: error: Name 'X86_REG_AL' is not defined
+ tests/auto_generators/make_dump.py:314: error: Name "X86_REG_AL" is not defined
- tests/auto_generators/make_dump.py:314: error: Name 'X86_REG_AX' is not defined
+ tests/auto_generators/make_dump.py:314: error: Name "X86_REG_AX" is not defined
- tests/auto_generators/make_dump.py:315: error: Name 'X86_REG_AX' is not defined
+ tests/auto_generators/make_dump.py:315: error: Name "X86_REG_AX" is not defined
- tests/auto_generators/make_dump.py:315: error: Name 'X86_REG_EAX' is not defined
+ tests/auto_generators/make_dump.py:315: error: Name "X86_REG_EAX" is not defined
- tests/auto_generators/make_dump.py:316: error: Name 'X86_REG_EAX' is not defined
+ tests/auto_generators/make_dump.py:316: error: Name "X86_REG_EAX" is not defined
- tests/auto_generators/make_dump.py:316: error: Name 'X86_REG_RAX' is not defined
+ tests/auto_generators/make_dump.py:316: error: Name "X86_REG_RAX" is not defined
- tests/auto_generators/make_dump.py:317: error: Name 'X86_REG_INVALID' is not defined
+ tests/auto_generators/make_dump.py:317: error: Name "X86_REG_INVALID" is not defined
- tests/auto_generators/make_dump.py:317: error: Name 'X86_REG_RAX' is not defined
+ tests/auto_generators/make_dump.py:317: error: Name "X86_REG_RAX" is not defined
- tests/auto_generators/make_dump.py:318: error: Name 'X86_REG_BH' is not defined
+ tests/auto_generators/make_dump.py:318: error: Name "X86_REG_BH" is not defined
- tests/auto_generators/make_dump.py:318: error: Name 'X86_REG_BX' is not defined
+ tests/auto_generators/make_dump.py:318: error: Name "X86_REG_BX" is not defined
- tests/auto_generators/make_dump.py:319: error: Name 'X86_REG_BL' is not defined
+ tests/auto_generators/make_dump.py:319: error: Name "X86_REG_BL" is not defined
- tests/auto_generators/make_dump.py:319: error: Name 'X86_REG_BX' is not defined
+ tests/auto_generators/make_dump.py:319: error: Name "X86_REG_BX" is not defined
- tests/auto_generators/make_dump.py:320: error: Name 'X86_REG_BX' is not defined
+ tests/auto_generators/make_dump.py:320: error: Name "X86_REG_BX" is not defined
- tests/auto_generators/make_dump.py:320: error: Name 'X86_REG_EBX' is not defined
+ tests/auto_generators/make_dump.py:320: error: Name "X86_REG_EBX" is not defined
- tests/auto_generators/make_dump.py:321: error: Name 'X86_REG_EBX' is not defined
+ tests/auto_generators/make_dump.py:321: error: Name "X86_REG_EBX" is not defined
- tests/auto_generators/make_dump.py:321: error: Name 'X86_REG_RBX' is not defined
+ tests/auto_generators/make_dump.py:321: error: Name "X86_REG_RBX" is not defined
- tests/auto_generators/make_dump.py:322: error: Name 'X86_REG_INVALID' is not defined
+ tests/auto_generators/make_dump.py:322: error: Name "X86_REG_INVALID" is not defined
- tests/auto_generators/make_dump.py:322: error: Name 'X86_REG_RBX' is not defined
+ tests/auto_generators/make_dump.py:322: error: Name "X86_REG_RBX" is not defined
- tests/auto_generators/make_dump.py:323: error: Name 'X86_REG_CH' is not defined
+ tests/auto_generators/make_dump.py:323: error: Name "X86_REG_CH" is not defined
- tests/auto_generators/make_dump.py:323: error: Name 'X86_REG_CX' is not defined
+ tests/auto_generators/make_dump.py:323: error: Name "X86_REG_CX" is not defined
- tests/auto_generators/make_dump.py:324: error: Name 'X86_REG_CL' is not defined
+ tests/auto_generators/make_dump.py:324: error: Name "X86_REG_CL" is not defined
- tests/auto_generators/make_dump.py:324: error: Name 'X86_REG_CX' is not defined
+ tests/auto_generators/make_dump.py:324: error: Name "X86_REG_CX" is not defined
- tests/auto_generators/make_dump.py:325: error: Name 'X86_REG_CX' is not defined
+ tests/auto_generators/make_dump.py:325: error: Name "X86_REG_CX" is not defined
- tests/auto_generators/make_dump.py:325: error: Name 'X86_REG_ECX' is not defined
+ tests/auto_generators/make_dump.py:325: error: Name "X86_REG_ECX" is not defined
- tests/auto_generators/make_dump.py:326: error: Name 'X86_REG_ECX' is not defined
+ tests/auto_generators/make_dump.py:326: error: Name "X86_REG_ECX" is not defined
- tests/auto_generators/make_dump.py:326: error: Name 'X86_REG_RCX' is not defined
+ tests/auto_generators/make_dump.py:326: error: Name "X86_REG_RCX" is not defined
- tests/auto_generators/make_dump.py:327: error: Name 'X86_REG_INVALID' is not defined
+ tests/auto_generators/make_dump.py:327: error: Name "X86_REG_INVALID" is not defined
- tests/auto_generators/make_dump.py:327: error: Name 'X86_REG_RCX' is not defined
+ tests/auto_generators/make_dump.py:327: error: Name "X86_REG_RCX" is not defined
- tests/auto_generators/make_dump.py:328: error: Name 'X86_REG_DH' is not defined
+ tests/auto_generators/make_dump.py:328: error: Name "X86_REG_DH" is not defined
- tests/auto_generators/make_dump.py:328: error: Name 'X86_REG_DX' is not defined
+ tests/auto_generators/make_dump.py:328: error: Name "X86_REG_DX" is not defined
- tests/auto_generators/make_dump.py:329: error: Name 'X86_REG_DL' is not defined
+ tests/auto_generators/make_dump.py:329: error: Name "X86_REG_DL" is not defined
- tests/auto_generators/make_dump.py:329: error: Name 'X86_REG_DX' is not defined
+ tests/auto_generators/make_dump.py:329: error: Name "X86_REG_DX" is not defined
- tests/auto_generators/make_dump.py:330: error: Name 'X86_REG_DX' is not defined
+ tests/auto_generators/make_dump.py:330: error: Name "X86_REG_DX" is not defined
- tests/auto_generators/make_dump.py:330: error: Name 'X86_REG_EDX' is not defined
+ tests/auto_generators/make_dump.py:330: error: Name "X86_REG_EDX" is not defined
- tests/auto_generators/make_dump.py:331: error: Name 'X86_REG_EDX' is not defined
+ tests/auto_generators/make_dump.py:331: error: Name "X86_REG_EDX" is not defined
- tests/auto_generators/make_dump.py:331: error: Name 'X86_REG_RDX' is not defined
+ tests/auto_generators/make_dump.py:331: error: Name "X86_REG_RDX" is not defined
- tests/auto_generators/make_dump.py:332: error: Name 'X86_REG_INVALID' is not defined
+ tests/auto_generators/make_dump.py:332: error: Name "X86_REG_INVALID" is not defined
- tests/auto_generators/make_dump.py:332: error: Name 'X86_REG_RDX' is not defined
+ tests/auto_generators/make_dump.py:332: error: Name "X86_REG_RDX" is not defined
- tests/auto_generators/make_dump.py:333: error: Name 'X86_REG_DIL' is not defined
+ tests/auto_generators/make_dump.py:333: error: Name "X86_REG_DIL" is not defined
- tests/auto_generators/make_dump.py:333: error: Name 'X86_REG_EDI' is not defined
+ tests/auto_generators/make_dump.py:333: error: Name "X86_REG_EDI" is not defined
- tests/auto_generators/make_dump.py:334: error: Name 'X86_REG_DI' is not defined
+ tests/auto_generators/make_dump.py:334: error: Name "X86_REG_DI" is not defined
- tests/auto_generators/make_dump.py:334: error: Name 'X86_REG_EDI' is not defined
+ tests/auto_generators/make_dump.py:334: error: Name "X86_REG_EDI" is not defined
- tests/auto_generators/make_dump.py:335: error: Name 'X86_REG_EDI' is not defined
+ tests/auto_generators/make_dump.py:335: error: Name "X86_REG_EDI" is not defined
- tests/auto_generators/make_dump.py:335: error: Name 'X86_REG_RDI' is not defined
+ tests/auto_generators/make_dump.py:335: error: Name "X86_REG_RDI" is not defined
- tests/auto_generators/make_dump.py:336: error: Name 'X86_REG_INVALID' is not defined
+ tests/auto_generators/make_dump.py:336: error: Name "X86_REG_INVALID" is not defined
- tests/auto_generators/make_dump.py:336: error: Name 'X86_REG_RDI' is not defined
+ tests/auto_generators/make_dump.py:336: error: Name "X86_REG_RDI" is not defined
- tests/auto_generators/make_dump.py:337: error: Name 'X86_REG_ESI' is not defined
+ tests/auto_generators/make_dump.py:337: error: Name "X86_REG_ESI" is not defined
- tests/auto_generators/make_dump.py:337: error: Name 'X86_REG_SIL' is not defined
+ tests/auto_generators/make_dump.py:337: error: Name "X86_REG_SIL" is not defined
- tests/auto_generators/make_dump.py:338: error: Name 'X86_REG_ESI' is not defined
+ tests/auto_generators/make_dump.py:338: error: Name "X86_REG_ESI" is not defined
- tests/auto_generators/make_dump.py:338: error: Name 'X86_REG_SI' is not defined
+ tests/auto_generators/make_dump.py:338: error: Name "X86_REG_SI" is not defined
- tests/auto_generators/make_dump.py:339: error: Name 'X86_REG_ESI' is not defined
+ tests/auto_generators/make_dump.py:339: error: Name "X86_REG_ESI" is not defined
- tests/auto_generators/make_dump.py:339: error: Name 'X86_REG_RSI' is not defined
+ tests/auto_generators/make_dump.py:339: error: Name "X86_REG_RSI" is not defined
- tests/auto_generators/make_dump.py:340: error: Name 'X86_REG_INVALID' is not defined
+ tests/auto_generators/make_dump.py:340: error: Name "X86_REG_INVALID" is not defined
- tests/auto_generators/make_dump.py:340: error: Name 'X86_REG_RSI' is not defined
+ tests/auto_generators/make_dump.py:340: error: Name "X86_REG_RSI" is not defined
- tests/auto_generators/make_dump.py:370: error: Name 'X86_OP_IMM' is not defined
+ tests/auto_generators/make_dump.py:370: error: Name "X86_OP_IMM" is not defined
- tests/auto_generators/make_dump.py:372: error: Name 'X86_OP_REG' is not defined
+ tests/auto_generators/make_dump.py:372: error: Name "X86_OP_REG" is not defined
- tests/auto_generators/make_dump.py:375: error: Name 'X86_OP_MEM' is not defined
+ tests/auto_generators/make_dump.py:375: error: Name "X86_OP_MEM" is not defined
- tests/auto_generators/make_dump.py:390: error: Name 'xrange' is not defined
+ tests/auto_generators/make_dump.py:390: error: Name "xrange" is not defined


kornia (https://github.com/kornia/kornia.git)
- kornia/augmentation/functional/functional3d.py:39: error: Name '_transform_input3d' is not defined
+ kornia/augmentation/functional/functional3d.py:39: error: Name "_transform_input3d" is not defined
- kornia/augmentation/functional/functional3d.py:58: error: Name '_transform_input3d' is not defined
+ kornia/augmentation/functional/functional3d.py:58: error: Name "_transform_input3d" is not defined
- kornia/augmentation/functional/functional3d.py:77: error: Name '_transform_input3d' is not defined
+ kornia/augmentation/functional/functional3d.py:77: error: Name "_transform_input3d" is not defined

tornado (https://github.com/tornadoweb/tornado.git)
- tornado/test/gettext_translations/extract_me.py:11: error: Name '_' is not defined
+ tornado/test/gettext_translations/extract_me.py:11: error: Name "_" is not defined
- tornado/test/gettext_translations/extract_me.py:12: error: Name 'pgettext' is not defined
+ tornado/test/gettext_translations/extract_me.py:12: error: Name "pgettext" is not defined
- tornado/test/gettext_translations/extract_me.py:13: error: Name 'pgettext' is not defined
+ tornado/test/gettext_translations/extract_me.py:13: error: Name "pgettext" is not defined
- tornado/test/gettext_translations/extract_me.py:14: error: Name 'pgettext' is not defined
+ tornado/test/gettext_translations/extract_me.py:14: error: Name "pgettext" is not defined
- tornado/test/gettext_translations/extract_me.py:15: error: Name 'pgettext' is not defined
+ tornado/test/gettext_translations/extract_me.py:15: error: Name "pgettext" is not defined

isort (https://github.com/pycqa/isort.git)
- isort/_vendored/toml/decoder.py:654: error: Name 'self._dict' is not defined
+ isort/_vendored/toml/decoder.py:654: error: Name "self._dict" is not defined

@JelleZijlstra JelleZijlstra merged commit 2a43cb9 into python:master Apr 4, 2021
@JelleZijlstra
Copy link
Member

Thanks!

@dixith dixith deleted the double-quotes-errors branch April 5, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants