Use double quotes in error messages for more consistent colors

[JukkaL]

Some messages use double quotes for quoting while other use single quotes. Maybe we should move to double quotes since the colored output only highlights double quoted strings.

Examples where this happens:

t.py:14: note: Revealed type is 'builtins.list[builtins.str*]'
t.py:27: error: Name 'asdf' is not defined

[ilevkivskyi]

Some more examples:

Cannot redefine 'a' as a NewType
Cannot redefine 'T' as a type variable
Unsupported type Type["Tuple[int]"]   # this one is especially weird
Cannot determine type of 'blah'
Cannot determine type of 'foo' in base class 'B'
Cannot instantiate abstract class 'A'
TypedDict key 'x' cannot be deleted  # and several other TypedDict related errors

[ilevkivskyi]

Also #5072 is kind of related because type representations can be unnecessary long.

[Patil2099]

@JukkaL Can I work on this issue? Also, Can you explain where I have to make the changes?
Thanks!

[JukkaL]

@Patil2099 Sure! Here are some hints:

• You'll need to update both the error message generation code and any tests that test for that error message.
• You can use grep to find where the error message is being generated/tested for.
• It's best to update one error message per PR, since the PRs may get quickly stale.
• Regular expressions are helpful.

[Sechan-BL]

I would like to work on this issue. So please can you guide me what to do and where to start my work?

[JelleZijlstra]

@Sechan-tkd you can look for places where we currently emit single-quoted strings, perhaps by reading through mypy/messages.py or through our test cases.

[Sechan-BL]

@Sechan-tkd you can look for places where we currently emit single-quoted strings, perhaps by reading through mypy/messages.py or through our test cases.

Should I need to update every single-quoted strings to double-quoted strings? Or else what should I do?

[JukkaL]

Should I need to update every single-quoted strings to double-quoted strings? Or else what should I do?

You can update one kind of message (or several messages) at a time, and fix any test failures that result from this. Even a single updated message is good enough for a PR -- no need to do everything at once. However, it's important to also update tests.

[Sechan-BL]

I dont know how to do . Can you please guide me with this? Like where to get the code ? What changes to make ?

[JukkaL]

@Sechan-tkd You start by reading the readme at the root of the repo and the docs linked to from it. They explain the basics.

[PrasanthChettri]

This is not taken right, I want to do this, seems doable even for a noob like me !