Use double quotes errors 'is not defined' and 'Cannot instantiate' (#10278)

Author: dixith

docs/source/common_issues.rst

@@ -218,7 +218,7 @@ version of Python considers legal code. These can result in some of the
 following errors when trying to run your code:
 
 * ``ImportError`` from circular imports
-* ``NameError: name 'X' is not defined`` from forward references
+* ``NameError: name "X" is not defined`` from forward references
 * ``TypeError: 'type' object is not subscriptable`` from types that are not generic at runtime
 * ``ImportError`` or ``ModuleNotFoundError`` from use of stub definitions not available at runtime
 * ``TypeError: unsupported operand type(s) for |: 'type' and 'type'`` from use of new syntax

docs/source/error_code_list.rst

@@ -87,7 +87,7 @@ This example accidentally calls ``sort()`` instead of :py:func:`sorted`:
 
 .. code-block:: python
 
-    x = sort([3, 2, 4])  # Error: Name 'sort' is not defined  [name-defined]
+    x = sort([3, 2, 4])  # Error: Name "sort" is not defined  [name-defined]
 
 Check arguments in calls [call-arg]
 -----------------------------------
@@ -565,7 +565,7 @@ Example:
 
         ...  # No "save" method
 
-    # Error: Cannot instantiate abstract class 'Thing' with abstract attribute 'save'  [abstract]
+    # Error: Cannot instantiate abstract class "Thing" with abstract attribute "save"  [abstract]
     t = Thing()
 
 Check the target of NewType [valid-newtype]

docs/source/runtime_troubles.rst

@@ -108,7 +108,7 @@ defined (aka forward reference). Thus this code does not work as expected:
 
 .. code-block:: python
 
-   def f(x: A) -> None: ...  # NameError: name 'A' is not defined
+   def f(x: A) -> None: ...  # NameError: name "A" is not defined
    class A: ...
 
 Starting from Python 3.7, you can add ``from __future__ import annotations`` to

mypy/messages.py

@@ -931,9 +931,9 @@ def incompatible_conditional_function_def(self, defn: FuncDef) -> None:
     def cannot_instantiate_abstract_class(self, class_name: str,
                                           abstract_attributes: List[str],
                                           context: Context) -> None:
-        attrs = format_string_list(["'%s'" % a for a in abstract_attributes])
-        self.fail("Cannot instantiate abstract class '%s' with abstract "
-                  "attribute%s %s" % (class_name, plural_s(abstract_attributes),
+        attrs = format_string_list(['"%s"' % a for a in abstract_attributes])
+        self.fail('Cannot instantiate abstract class "%s" with abstract '
+                  'attribute%s %s' % (class_name, plural_s(abstract_attributes),
                                    attrs),
                   context, code=codes.ABSTRACT)
 

mypy/semanal.py

@@ -4731,7 +4731,7 @@ def name_not_defined(self, name: str, ctx: Context, namespace: Optional[str] = N
             # later on. Defer current target.
             self.record_incomplete_ref()
             return
-        message = "Name '{}' is not defined".format(name)
+        message = 'Name "{}" is not defined'.format(name)
         self.fail(message, ctx, code=codes.NAME_DEFINED)
 
         if 'builtins.{}'.format(name) in SUGGESTED_TEST_FIXTURES:

mypy/typeanal.py

@@ -286,7 +286,7 @@ def try_analyze_special_unbound_type(self, t: UnboundType, fullname: str) -> Opt
                 if self.api.is_incomplete_namespace('builtins'):
                     self.api.record_incomplete_ref()
                 else:
-                    self.fail("Name 'tuple' is not defined", t)
+                    self.fail('Name "tuple" is not defined', t)
                 return AnyType(TypeOfAny.special_form)
             if len(t.args) == 0 and not t.empty_tuple_index:
                 # Bare 'Tuple' is same as 'tuple'

mypyc/irbuild/ll_builder.py

@@ -593,7 +593,7 @@ def load_static_checked(self, typ: RType, identifier: str, module_name: Optional
                             line: int = -1,
                             error_msg: Optional[str] = None) -> Value:
         if error_msg is None:
-            error_msg = "name '{}' is not defined".format(identifier)
+            error_msg = 'name "{}" is not defined'.format(identifier)
         ok_block, error_block = BasicBlock(), BasicBlock()
         value = self.add(LoadStatic(typ, identifier, module_name, namespace, line=line))
         self.add(Branch(value, error_block, ok_block, Branch.IS_ERROR, rare=True))

mypyc/test-data/analysis.test

@@ -518,7 +518,7 @@ L6:
 (6, 0)   {a}                     {a}
 
 [case testError]
-def f(x: List[int]) -> None: pass # E: Name 'List' is not defined \
+def f(x: List[int]) -> None: pass # E: Name "List" is not defined \
                                   # N: Did you forget to import it from "typing"? (Suggestion: "from typing import List")
 
 [case testExceptUndefined_Liveness]

mypyc/test-data/irbuild-basic.test

@@ -539,12 +539,12 @@ def f() -> None:
     return 1 # E: No return value expected
 
 [case testReportSemanticaAnalysisError1]
-def f(x: List[int]) -> None: pass # E: Name 'List' is not defined \
+def f(x: List[int]) -> None: pass # E: Name "List" is not defined \
                                   # N: Did you forget to import it from "typing"? (Suggestion: "from typing import List")
 
 [case testReportSemanticaAnalysisError2]
 def f() -> None:
-    x # E: Name 'x' is not defined
+    x # E: Name "x" is not defined
 
 [case testElif]
 def f(n: int) -> int:

mypyc/test-data/refcount.test

@@ -533,7 +533,7 @@ L0:
     return r1
 
 [case testError]
-def f(x: List[int]) -> None: pass # E: Name 'List' is not defined \
+def f(x: List[int]) -> None: pass # E: Name "List" is not defined \
                                   # N: Did you forget to import it from "typing"? (Suggestion: "from typing import List")
 
 [case testNewList]