Skip to content

gh-99430: Remove duplicated tests for old-styled classes #99432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2022
Merged

gh-99430: Remove duplicated tests for old-styled classes #99432

merged 1 commit into from
Nov 13, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 13, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Nov 13, 2022
Closed
7 tasks
gpshead
gpshead approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out with the old! =)

@gpshead gpshead merged commit d329f85 into python:main Nov 13, 2022
@sobolevn
Copy link
Member Author

Thank you! 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 11, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn and @gpshead, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d329f859b9cea9e6fa76fdf03927f659cf17786b 3.11

@miss-islington-app
Copy link

Sorry, @sobolevn and @gpshead, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d329f859b9cea9e6fa76fdf03927f659cf17786b 3.12

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Feb 11, 2024
@sobolevn @serhiy-storchaka
[3.11] pythongh-99430: Remove duplicated tests for old-styled classes (…
d88cd04 
…pythonGH-99432)

python 1 & 2 were a loong time ago.
(cherry picked from commit d329f85)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 11, 2024

GH-115298 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 11, 2024
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.12 only security fixes label Feb 11, 2024
@serhiy-storchaka
Copy link
Member

Backporting helps to backport other test changes.

serhiy-storchaka added a commit that referenced this pull request Feb 11, 2024
@serhiy-storchaka @sobolevn
[3.11] gh-99430: Remove duplicated tests for old-styled classes (GH-9…
75d92f5 
…9432) (GH-115298)

python 1 & 2 were a loong time ago.
(cherry picked from commit d329f85)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @serhiy-storchaka @gpshead @bedevere-bot