Skip to content

Commit 75d92f5

Browse files
[3.11] gh-99430: Remove duplicated tests for old-styled classes (GH-99432) (GH-115298)
python 1 & 2 were a loong time ago. (cherry picked from commit d329f85) Co-authored-by: Nikita Sobolev <[email protected]>
1 parent 7273a58 commit 75d92f5

File tree

5 files changed

+6
-139
lines changed

5 files changed

+6
-139
lines changed

Lib/test/pydocfodder.py

Lines changed: 1 addition & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -2,85 +2,7 @@
22

33
import types
44

5-
class A_classic:
6-
"A classic class."
7-
def A_method(self):
8-
"Method defined in A."
9-
def AB_method(self):
10-
"Method defined in A and B."
11-
def AC_method(self):
12-
"Method defined in A and C."
13-
def AD_method(self):
14-
"Method defined in A and D."
15-
def ABC_method(self):
16-
"Method defined in A, B and C."
17-
def ABD_method(self):
18-
"Method defined in A, B and D."
19-
def ACD_method(self):
20-
"Method defined in A, C and D."
21-
def ABCD_method(self):
22-
"Method defined in A, B, C and D."
23-
24-
25-
class B_classic(A_classic):
26-
"A classic class, derived from A_classic."
27-
def AB_method(self):
28-
"Method defined in A and B."
29-
def ABC_method(self):
30-
"Method defined in A, B and C."
31-
def ABD_method(self):
32-
"Method defined in A, B and D."
33-
def ABCD_method(self):
34-
"Method defined in A, B, C and D."
35-
def B_method(self):
36-
"Method defined in B."
37-
def BC_method(self):
38-
"Method defined in B and C."
39-
def BD_method(self):
40-
"Method defined in B and D."
41-
def BCD_method(self):
42-
"Method defined in B, C and D."
43-
44-
class C_classic(A_classic):
45-
"A classic class, derived from A_classic."
46-
def AC_method(self):
47-
"Method defined in A and C."
48-
def ABC_method(self):
49-
"Method defined in A, B and C."
50-
def ACD_method(self):
51-
"Method defined in A, C and D."
52-
def ABCD_method(self):
53-
"Method defined in A, B, C and D."
54-
def BC_method(self):
55-
"Method defined in B and C."
56-
def BCD_method(self):
57-
"Method defined in B, C and D."
58-
def C_method(self):
59-
"Method defined in C."
60-
def CD_method(self):
61-
"Method defined in C and D."
62-
63-
class D_classic(B_classic, C_classic):
64-
"A classic class, derived from B_classic and C_classic."
65-
def AD_method(self):
66-
"Method defined in A and D."
67-
def ABD_method(self):
68-
"Method defined in A, B and D."
69-
def ACD_method(self):
70-
"Method defined in A, C and D."
71-
def ABCD_method(self):
72-
"Method defined in A, B, C and D."
73-
def BD_method(self):
74-
"Method defined in B and D."
75-
def BCD_method(self):
76-
"Method defined in B, C and D."
77-
def CD_method(self):
78-
"Method defined in C and D."
79-
def D_method(self):
80-
"Method defined in D."
81-
82-
83-
class A_new(object):
5+
class A_new:
846
"A new-style class."
857

868
def A_method(self):

Lib/test/test_copy.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,7 @@ def __getattribute__(self, name):
9191
# Type-specific _copy_xxx() methods
9292

9393
def test_copy_atomic(self):
94-
class Classic:
95-
pass
96-
class NewStyle(object):
94+
class NewStyle:
9795
pass
9896
def f():
9997
pass
@@ -103,7 +101,7 @@ class WithMetaclass(metaclass=abc.ABCMeta):
103101
42, 2**100, 3.14, True, False, 1j,
104102
"hello", "hello\u1234", f.__code__,
105103
b"world", bytes(range(256)), range(10), slice(1, 10, 2),
106-
NewStyle, Classic, max, WithMetaclass, property()]
104+
NewStyle, max, WithMetaclass, property()]
107105
for x in tests:
108106
self.assertIs(copy.copy(x), x)
109107

@@ -356,15 +354,13 @@ def __getattribute__(self, name):
356354
# Type-specific _deepcopy_xxx() methods
357355

358356
def test_deepcopy_atomic(self):
359-
class Classic:
360-
pass
361-
class NewStyle(object):
357+
class NewStyle:
362358
pass
363359
def f():
364360
pass
365361
tests = [None, ..., NotImplemented, 42, 2**100, 3.14, True, False, 1j,
366362
b"bytes", "hello", "hello\u1234", f.__code__,
367-
NewStyle, range(10), Classic, max, property()]
363+
NewStyle, range(10), max, property()]
368364
for x in tests:
369365
self.assertIs(copy.deepcopy(x), x)
370366

Lib/test/test_descr.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3256,12 +3256,8 @@ def __get__(self, object, otype):
32563256
if otype:
32573257
otype = otype.__name__
32583258
return 'object=%s; type=%s' % (object, otype)
3259-
class OldClass:
3259+
class NewClass:
32603260
__doc__ = DocDescr()
3261-
class NewClass(object):
3262-
__doc__ = DocDescr()
3263-
self.assertEqual(OldClass.__doc__, 'object=None; type=OldClass')
3264-
self.assertEqual(OldClass().__doc__, 'object=OldClass instance; type=OldClass')
32653261
self.assertEqual(NewClass.__doc__, 'object=None; type=NewClass')
32663262
self.assertEqual(NewClass().__doc__, 'object=NewClass instance; type=NewClass')
32673263

Lib/test/test_gc.py

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -542,48 +542,6 @@ def __getattr__(self, someattribute):
542542
self.assertEqual(gc.collect(), 2)
543543
self.assertEqual(len(gc.garbage), garbagelen)
544544

545-
def test_boom_new(self):
546-
# boom__new and boom2_new are exactly like boom and boom2, except use
547-
# new-style classes.
548-
549-
class Boom_New(object):
550-
def __getattr__(self, someattribute):
551-
del self.attr
552-
raise AttributeError
553-
554-
a = Boom_New()
555-
b = Boom_New()
556-
a.attr = b
557-
b.attr = a
558-
559-
gc.collect()
560-
garbagelen = len(gc.garbage)
561-
del a, b
562-
self.assertEqual(gc.collect(), 2)
563-
self.assertEqual(len(gc.garbage), garbagelen)
564-
565-
def test_boom2_new(self):
566-
class Boom2_New(object):
567-
def __init__(self):
568-
self.x = 0
569-
570-
def __getattr__(self, someattribute):
571-
self.x += 1
572-
if self.x > 1:
573-
del self.attr
574-
raise AttributeError
575-
576-
a = Boom2_New()
577-
b = Boom2_New()
578-
a.attr = b
579-
b.attr = a
580-
581-
gc.collect()
582-
garbagelen = len(gc.garbage)
583-
del a, b
584-
self.assertEqual(gc.collect(), 2)
585-
self.assertEqual(len(gc.garbage), garbagelen)
586-
587545
def test_get_referents(self):
588546
alist = [1, 3, 5]
589547
got = gc.get_referents(alist)

Lib/test/test_unicode.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2443,12 +2443,7 @@ class s1:
24432443
def __repr__(self):
24442444
return '\\n'
24452445

2446-
class s2:
2447-
def __repr__(self):
2448-
return '\\n'
2449-
24502446
self.assertEqual(repr(s1()), '\\n')
2451-
self.assertEqual(repr(s2()), '\\n')
24522447

24532448
def test_printable_repr(self):
24542449
self.assertEqual(repr('\U00010000'), "'%c'" % (0x10000,)) # printable

0 commit comments

Comments
 (0)