Skip to content

GH-96177: Move GIL and some threading code out of ceval.c into gil.c. #96204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 24, 2022
Merged

GH-96177: Move GIL and some threading code out of ceval.c into gil.c. #96204

merged 4 commits into from
Aug 24, 2022

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 23, 2022 •
edited by bedevere-bot
Loading

Nothing clever here, just moving the code relevant to the GIL from ceval.c and ceval_gil.h into the new file gil.c

@markshannon markshannon requested a review from a team as a code owner August 23, 2022 10:06
@markshannon
Copy link
Member Author

Skipping NEWS as this has no effect on anything visible.

ericsnowcurrently
ericsnowcurrently reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

My only concern is that "gil.c" has much more than the GIL stuff. A more accurate name might be "gil_and_eval_breaker.c" or "ceval_state.c".

@markshannon
Copy link
Member Author

I've renamed it as ceval_gil.c to make it a bit clearer that isn't all the code for the GIL (or just the code for the GIL).

@markshannon markshannon merged commit a4a9f2e into python:main Aug 24, 2022
mdboom pushed a commit to mdboom/cpython that referenced this pull request Aug 24, 2022
@markshannon @mdboom
pythonGH-96177: Move GIL and eval breaker code out of ceval.c into ce…
f5d03d9 
…val_gil.c. (pythonGH-96204)
@kumaraditya303 kumaraditya303 mentioned this pull request Sep 6, 2022
Closed
@markshannon markshannon deleted the move-gil-code branch September 26, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markshannon @ericsnowcurrently @bedevere-bot