-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Move GIL code into its own file #96177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hopefully this will also ease maintenance of the GIL code. Having it in one place makes it easier to understand. |
markshannon
added a commit
that referenced
this issue
Aug 24, 2022
mdboom
pushed a commit
to mdboom/cpython
that referenced
this issue
Aug 24, 2022
#96204 moved the code to new file, @markshannon anything left to do here ? |
Should this be closed? |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the GIL code lives in ceval.c
ceval.c is a large file (8k lines) and doesn't need to contain the GIL code.
It used to, as it was quite tightly coupled with the interpreter, but that is no longer the case.
Apart from general code health, moving the GIL code to its own file will ease generating the interpreter and other performance work.
The text was updated successfully, but these errors were encountered: