[3.7] bpo-42773: fix tests not being run on pushes (GH-24004) #92341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ned-deily merged 1 commit into python:3.7 from miss-islington:backport-4ac923f-3.7

May 6, 2022

Contributor

miss-islington commented May 5, 2022

There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns [email protected]
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns [email protected]


          bpo-42773: fix tests not being run on pushes (pythonGH-24004)

86dd591

There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <[email protected]>
(cherry picked from commit 4ac923f)

Co-authored-by: Filipe Laíns <[email protected]>

bedevere-bot mentioned this pull request

bpo-42773: fix tests not being run on pushes #24004

Merged

bedevere-bot added skip news awaiting review labels

Contributor Author

miss-islington commented May 5, 2022

@FFY00: Status check is done, and it's a success ✅ .

JelleZijlstra approved these changes

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Contributor Author

miss-islington commented May 5, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

JelleZijlstra mentioned this pull request

[3.7] gh-80254: Disallow recursive usage of cursors in sqlite3 converters #92334

Merged

Contributor Author

miss-islington commented May 5, 2022

@FFY00: Status check is done, and it's a success ✅ .

1 similar comment

Contributor Author

miss-islington commented May 5, 2022

@FFY00: Status check is done, and it's a success ✅ .

Contributor Author

miss-islington commented May 5, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

Contributor Author

miss-islington commented May 5, 2022

@FFY00: Status check is done, and it's a success ✅ .

Contributor Author

miss-islington commented May 5, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

Contributor Author

miss-islington commented May 5, 2022

@FFY00: Status check is done, and it's a success ✅ .

Contributor Author

miss-islington commented May 5, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

Contributor Author

miss-islington commented May 5, 2022

@FFY00: Status check is done, and it's a success ✅ .

Contributor Author

miss-islington commented May 5, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

1 similar comment

Contributor Author

miss-islington commented May 5, 2022

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

kumaraditya303 assigned ned-deily

ned-deily merged commit 5adef3d into python:3.7

bedevere-bot removed the awaiting merge label

miss-islington deleted the backport-4ac923f-3.7 branch

May 6, 2022 17:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels