Skip to content

Commit 4ac923f

Browse files
authored
bpo-42773: fix tests not being run on pushes (GH-24004)
There was a typo, we were checking if the "GITHUB_BASE_REF" string literal was empty instead of the $GITHUB_BASE_REF value. When $GITHUB_BASE_REF is empty, the action that triggered the run was not a pull request, so we always run the full test suite. Signed-off-by: Filipe Laíns <[email protected]>
1 parent 277ce30 commit 4ac923f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- name: Check for source changes
2929
id: check
3030
run: |
31-
if [ -z "GITHUB_BASE_REF" ]; then
31+
if [ -z "$GITHUB_BASE_REF" ]; then
3232
echo '::set-output name=run_tests::true'
3333
else
3434
git fetch origin $GITHUB_BASE_REF --depth=1

0 commit comments

Comments
 (0)