Skip to content

bpo-33717: set terse=True in pythoninfo.collect_platform #7797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2018
Merged

bpo-33717: set terse=True in pythoninfo.collect_platform #7797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/pythoninfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def collect_platform(info_add):
info_add('platform.python_implementation',
platform.python_implementation())
info_add('platform.platform',
platform.platform(aliased=True))
platform.platform(aliased=True, terse=True))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like terse=True returns less information.

platform.platform(aliased=True)
'Linux-4.16.14-300.fc28.x86_64-x86_64-with-fedora-28-Twenty_Eight'
platform.platform(aliased=True,terse=True)
'Linux-4.16.14-300.fc28.x86_64-x86_64-with-glibc2.3.4'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distribution info. platform.dist is deprecated long ago and the buildbot already tells us what the exact distribution is. The info is already not available in master.



def collect_locale(info_add):
Expand Down