bpo-33717: set terse=True in pythoninfo.collect_platform #7797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
changed the title
vstinner
reviewed
Jun 19, 2018
| @@ -142,7 +142,7 @@ def collect_platform(info_add): | |||
| info_add('platform.python_implementation', | |||
| platform.python_implementation()) | |||
| info_add('platform.platform', | |||
| platform.platform(aliased=True)) | |||
| platform.platform(aliased=True, terse=True)) | |||
There was a problem hiding this comment.
It seems like terse=True returns less information.
platform.platform(aliased=True)
'Linux-4.16.14-300.fc28.x86_64-x86_64-with-fedora-28-Twenty_Eight'
platform.platform(aliased=True,terse=True)
'Linux-4.16.14-300.fc28.x86_64-x86_64-with-glibc2.3.4'
There was a problem hiding this comment.
The distribution info. platform.dist is deprecated long ago and the buildbot already tells us what the exact distribution is. The info is already not available in master.
|
Thanks @zhangyangyu for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 19, 2018
…ythonGH-7797) (cherry picked from commit 71ca738) Co-authored-by: Xiang Zhang <[email protected]>
|
GH-7802 is a backport of this pull request to the 3.6 branch. |
|
GH-7803 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 19, 2018
…ythonGH-7797) (cherry picked from commit 71ca738) Co-authored-by: Xiang Zhang <[email protected]>
zhangyangyu
added a commit
that referenced
this pull request
Jun 19, 2018
…ythoninfo (GH-7797) (GH-7803) (cherry picked from commit 71ca738) Co-authored-by: Xiang Zhang <[email protected]>
zhangyangyu
added a commit
that referenced
this pull request
Jun 19, 2018
…ythoninfo (GH-7797) (GH-7802) (cherry picked from commit 71ca738) Co-authored-by: Xiang Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest using
platform.platform(aliased=True, terse=True)in test.pythoninfo in < 3.8. This makes it more consistent with 3.8.platform.platformis largely changed in 3.8. More specially, I want libc version to be included in pythoninfo. Although libc version is wrong now but I think it will be fixed soon.https://bugs.python.org/issue33717