python · serhiy-storchaka · Sep 13, 2017 · Sep 13, 2017 · Sep 13, 2017 · Sep 13, 2017
diff --git a/Misc/NEWS.d/next/Core and Builtins/2017-09-13-13-03-52.bpo-31418.rS-FlC.rst b/Misc/NEWS.d/next/Core and Builtins/2017-09-13-13-03-52.bpo-31418.rS-FlC.rst
@@ -0,0 +1,2 @@
+Fix an assertion failure in `c.PyErr_WriteUnraisable()` in case of an
+exception with a bad ``__module__`` attribute. Patch by Oren Milman.
diff --git a/Python/errors.c b/Python/errors.c
@@ -961,7 +961,7 @@ PyErr_WriteUnraisable(PyObject *obj)
     }
 
     moduleName = _PyObject_GetAttrId(t, &PyId___module__);
-    if (moduleName == NULL) {
+    if (moduleName == NULL || !PyUnicode_Check(moduleName)) {
         PyErr_Clear();
         if (PyFile_WriteString("<unknown>", f) < 0)
             goto done;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Fix an assertion failure in `c.PyErr_WriteUnraisable()` in case of an
Copy link Member serhiy-storchaka Sep 13, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. What is `c.PyErr_WriteUnraisable()`? Copy link Contributor Author orenmn Sep 13, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. https://devguide.python.org/committing/#what-s-new-and-news-entries says: `(single backticks) in reST can be used to refer to objects in the documentation.` I thought this means that i should specify (inside single backticks) an object in the docs, according to how it appears in the docs (i.e. when pressing the `Permalink to this definition` button - https://docs.python.org/3.7/c-api/exceptions.html#c.PyErr_WriteUnraisable). so it should just be `PyErr_WriteUnraisable()`? Copy link Member serhiy-storchaka Sep 13, 2017 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Yes, it should be without "c." prefix.
		exception with a bad ``__module__`` attribute. Patch by Oren Milman.